Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] distutils3: Avoid MACHINE specific checksums
Date: Wed, 30 Sep 2015 16:43:03 +0200	[thread overview]
Message-ID: <20150930144303.GC2405@jama> (raw)
In-Reply-To: <1443621275.5162.95.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 2690 bytes --]

On Wed, Sep 30, 2015 at 02:54:35PM +0100, Richard Purdie wrote:
> The MACHINE variable is used to handle sysroot paths within one of the
> patches to python3-native. In this context, it is relocation safe and
> the resulting packages should not have MACHINE specific checksums,
> therefore excluding MACHINE in this context is safe.
> 
> This whole setup is ugly and ideally we should come up with a better
> way of handling this but at least allow a stop gap solution for now.

There was some short discussion about this long time ago:
http://patchwork.openembedded.org/patch/74129/

I'm still using that patch and still haven't found any issues caused by
that, but I'm not using python3 recipes (except building them in world),
so it's possible I've just overlooked them.

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> diff --git a/meta/classes/distutils3.bbclass b/meta/classes/distutils3.bbclass
> index e909ef4..443bf3a 100644
> --- a/meta/classes/distutils3.bbclass
> +++ b/meta/classes/distutils3.bbclass
> @@ -21,6 +21,7 @@ distutils3_do_compile() {
>          build ${DISTUTILS_BUILD_ARGS} || \
>          bbfatal "${PYTHON_PN} setup.py build_ext execution failed."
>  }
> +distutils3_do_compile[vardepsexclude] = "MACHINE"
>  
>  distutils3_stage_headers() {
>          install -d ${STAGING_DIR_HOST}${PYTHON_SITEPACKAGES_DIR}
> @@ -33,6 +34,7 @@ distutils3_stage_headers() {
>          ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN} setup.py install_headers ${DISTUTILS_STAGE_HEADERS_ARGS} || \
>          bbfatal "${PYTHON_PN} setup.py install_headers execution failed."
>  }
> +distutils3_stage_headers[vardepsexclude] = "MACHINE"
>  
>  distutils3_stage_all() {
>          if [ ${BUILD_SYS} != ${HOST_SYS} ]; then
> @@ -48,6 +50,7 @@ distutils3_stage_all() {
>          ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN} setup.py install ${DISTUTILS_STAGE_ALL_ARGS} || \
>          bbfatal "${PYTHON_PN} setup.py install (stage) execution failed."
>  }
> +distutils3_stage_all[vardepsexclude] = "MACHINE"
>  
>  distutils3_do_install() {
>          install -d ${D}${PYTHON_SITEPACKAGES_DIR}
> @@ -90,6 +93,7 @@ distutils3_do_install() {
>              rmdir ${D}${datadir}/share
>          fi
>  }
> +distutils3_do_install[vardepsexclude] = "MACHINE"
>  
>  EXPORT_FUNCTIONS do_compile do_install
>  
> 
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2015-09-30 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 13:54 [PATCH] distutils3: Avoid MACHINE specific checksums Richard Purdie
2015-09-30 14:43 ` Martin Jansa [this message]
2015-09-30 15:01   ` Burton, Ross
2015-09-30 15:56     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930144303.GC2405@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox