Re: [PATCH v2] uievent: refactor retry loop

[Ed Bartosh <ed.bartosh@linux.intel.com>]

wrong list. please ignore.

On Mon, Jan 04, 2016 at 10:12:16AM +0200, Ed Bartosh wrote:
> Replaced 'while' loop with 'for' loop.
> Made the code more compact and hopefully more understandable.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  bitbake/lib/bb/ui/uievent.py | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/bitbake/lib/bb/ui/uievent.py b/bitbake/lib/bb/ui/uievent.py
> index 19a9301..af239a3 100644
> --- a/bitbake/lib/bb/ui/uievent.py
> +++ b/bitbake/lib/bb/ui/uievent.py
> @@ -45,27 +45,25 @@ class BBUIEventQueue:
>          server.socket.settimeout(1)
>  
>          self.EventHandle = None
> -        count_tries = 0
>  
>          # the event handler registration may fail here due to cooker being in invalid state
>          # this is a transient situation, and we should retry a couple of times before
>          # giving up
>  
> -        while self.EventHandle == None and count_tries < 5:
> +        for count_tries in range(5):
> +
>              self.EventHandle, error = self.BBServer.registerEventHandler(self.host, self.port)
>  
> -            if (self.EventHandle != None):
> +            if self.EventHandle != None:
>                  break
>  
>              errmsg = "Could not register UI event handler. Error: %s, host %s, "
>                       "port %d" % (error, self.host, self.port))
>              bb.warn("%s, retry" % errmsg)
> -            count_tries += 1
> +
>              import time
>              time.sleep(1)
> -
> -
> -        if self.EventHandle == None:
> +        else:
>              raise Exception(errmsg)
>  
>          self.server = server
> -- 
> 2.1.4
> 

-- 
--
Regards,
Ed