From: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RESEND PATCH v3] util-linux: create util-linux-runuser package
Date: Tue, 12 Jan 2016 10:26:02 +0200 [thread overview]
Message-ID: <20160112102602.13095fdf@ionel-workpc.emea.corp.natinst.com> (raw)
In-Reply-To: <4152432.VEWvmsyppU@peggleto-mobl.ger.corp.intel.com>
On Tue, 12 Jan 2016 15:52:50 +1300
Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> On Wed, 23 Dec 2015 12:03:03 Ioan-Adrian Ratiu wrote:
> > On Tue, 22 Dec 2015 17:34:12 +0000
> >
> > "Burton, Ross" <ross.burton@intel.com> wrote:
> > > On 15 December 2015 at 09:49, Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> wrote:
> > > > Split runuser into its own package (previously provided by util-linux).
> > > > Since runuser is compiled only when DISTRO_FEATURES includes pam,
> > > > the creation of util-linux-runuser is also constrained by this.
> > >
> > > What's the rationale for pulling this out into a separate package?
> >
> > I need runuser on a busybox image and can't install the entire util-linux
> > package.
> > > > PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount',
> > > >
> > > > 'util-linux-pylibmount', '', d)}"
> > > > +PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam',
> > > > 'util-linux-runuser', '', d)}"
> > >
> > > No need for conditionals: empty packages are not created.
> >
> > Thank you for this tip, I've modified and sent v4.
>
> Unfortunately this wasn't right - the package being excluded from PACKAGES was
> serving to avoid the libpam dependency when pam was not in DISTRO_FEATURES; as
> of this patch we are now building it unconditionally leading to a warning.
>
> Ioan-Adrian, could you please send a patch that changes it back to how you had
> it in v3?
Yes, I'll send v5 which will revert the change from v4.
>
> Thanks,
> Paul
>
next prev parent reply other threads:[~2016-01-12 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 9:49 [RESEND PATCH v3] util-linux: create util-linux-runuser package Ioan-Adrian Ratiu
2015-12-22 17:34 ` Burton, Ross
2015-12-23 10:03 ` Ioan-Adrian Ratiu
2016-01-12 2:52 ` Paul Eggleton
2016-01-12 8:26 ` Ioan-Adrian Ratiu [this message]
2016-01-12 9:03 ` Ioan-Adrian Ratiu
2015-12-23 10:21 ` [PATCH v4] " Ioan-Adrian Ratiu
2016-01-08 9:02 ` Ioan-Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112102602.13095fdf@ionel-workpc.emea.corp.natinst.com \
--to=adrian.ratiu@ni.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox