From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 7AF1B77144 for ; Tue, 2 Feb 2016 16:15:16 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 02 Feb 2016 08:14:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,385,1449561600"; d="scan'208";a="875225146" Received: from linux.intel.com ([10.23.219.25]) by orsmga001.jf.intel.com with ESMTP; 02 Feb 2016 08:14:03 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id 918A26A4002; Tue, 2 Feb 2016 09:01:54 -0800 (PST) Date: Tue, 2 Feb 2016 16:04:26 +0200 From: Ed Bartosh To: Richard Purdie Message-ID: <20160202140426.GA32458@linux.intel.com> Reply-To: ed.bartosh@linux.intel.com References: <4a80d3209aa669db75e6343646ddb6a127ad8fc2.1454397260.git.ed.bartosh@linux.intel.com> <1454424619.27087.80.camel@linuxfoundation.org> <20160202125511.GA10780@linux.intel.com> <1454428628.27087.84.camel@linuxfoundation.org> MIME-Version: 1.0 In-Reply-To: <1454428628.27087.84.camel@linuxfoundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: openembedded-core@lists.openembedded.org Subject: Re: [wic][PATCH 02/15] runqemu: don't use virtio for wic images X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 16:15:21 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 02, 2016 at 03:57:08PM +0000, Richard Purdie wrote: > On Tue, 2016-02-02 at 14:55 +0200, Ed Bartosh wrote: > > On Tue, Feb 02, 2016 at 02:50:19PM +0000, Richard Purdie wrote: > > > On Tue, 2016-02-02 at 09:27 +0200, Ed Bartosh wrote: > > > > qemu hands with 'waiting for root device' message during the > > > > boot of wic images if '-drive if=virtio' option is used. > > > > > > > > Removed if=virtio from qemu command line for wic images. This > > > > should fix above mentioned boot issue. > > > > > > Does this not change the command for other image types too? > > No, it doesn't. This patch changes qemu command line only for wic > > images. > > Sorry, somehow I didn't see the second line in that diff which adds it > back. > > I do worry about creating too many codepaths in this code though. Any > idea why virtio doesn't work? I'll look at it and update patchset. Thanks for review! -- Regards, Ed