Re: [PATCH v2] formfactor: add machconfig for qemumips64 and beaglebone

From: Martin Jansa <martin.jansa@gmail.com>
To: "Maxin B. John" <maxin.john@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] formfactor: add machconfig for qemumips64 and beaglebone
Date: Wed, 3 Feb 2016 16:30:24 +0100	[thread overview]
Message-ID: <20160203153024.GC2567@jama> (raw)
In-Reply-To: <20160203150847.GB20736@mbabyjoh-mobl.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3151 bytes --]

On Wed, Feb 03, 2016 at 05:08:47PM +0200, Maxin B. John wrote:
> Hi Martin,
> 
> On Wed, Feb 03, 2016 at 04:02:56PM +0100, Martin Jansa wrote:
> > On Wed, Feb 03, 2016 at 12:30:08PM +0200, Maxin B. John wrote:
> > > We need machconfig file to automatically choose between physical and virtual
> > > keyboards.
> > > 
> > > [YOCTO #9027]
> > > 
> > > Signed-off-by: Maxin B. John <maxin.john@intel.com>
> > > ---
> > >  meta/recipes-bsp/formfactor/files/beaglebone/machconfig |  3 +++
> > 
> > I still don't understand why beaglebone specific file should be included
> > in oe-core, all other BSP layers are providing own machconfig for their
> > MACHINEs, why should beaglebone be first exception for oe-core?
> >
> Apart from what Ross mentioned before,

Is this for oe-core or meta-yocto-bsp? The subject doesn't say which and
path looks like for oe-core.

And if it's for meta-yocto-bsp, does it belong to yocto ML? There is no
README in meta-yocto-bsp root.

> commit 76b1d595cd7104797495067cc8c59db631edb75d
> Author: Denys Dmytriyenko <denys@ti.com>
> Date:   Wed Mar 26 15:21:10 2014 -0400
> 
> added beaglebone to meta-yocto-bsp. Before that, ARM reference board was
> beagleboard.
> 
> commit 7254dfb642cb0262c7e14ef2a4c8a7a42afada60
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Fri Mar 28 18:07:01 2014 +0000
> 
>     Drop beagleboard, replaced by beaglebone
> 
> > >  meta/recipes-bsp/formfactor/files/qemumips64/machconfig | 10 ++++++++++
> > >  2 files changed, 13 insertions(+)
> > >  create mode 100755 meta/recipes-bsp/formfactor/files/beaglebone/machconfig
> > >  create mode 100755 meta/recipes-bsp/formfactor/files/qemumips64/machconfig
> > > 
> > > diff --git a/meta/recipes-bsp/formfactor/files/beaglebone/machconfig b/meta/recipes-bsp/formfactor/files/beaglebone/machconfig
> > > new file mode 100755
> > > index 0000000..ffce012
> > > --- /dev/null
> > > +++ b/meta/recipes-bsp/formfactor/files/beaglebone/machconfig
> > > @@ -0,0 +1,3 @@
> > > +# Assume a USB mouse and keyboard are connected
> > > +HAVE_TOUCHSCREEN=0
> > > +HAVE_KEYBOARD=1
> > > diff --git a/meta/recipes-bsp/formfactor/files/qemumips64/machconfig b/meta/recipes-bsp/formfactor/files/qemumips64/machconfig
> > > new file mode 100755
> > > index 0000000..56777b6
> > > --- /dev/null
> > > +++ b/meta/recipes-bsp/formfactor/files/qemumips64/machconfig
> > > @@ -0,0 +1,10 @@
> > > +HAVE_TOUCHSCREEN=1
> > > +HAVE_KEYBOARD=1
> > > + 
> > > +DISPLAY_CAN_ROTATE=0
> > > +DISPLAY_ORIENTATION=0
> > > +DISPLAY_WIDTH_PIXELS=640
> > > +DISPLAY_HEIGHT_PIXELS=480
> > > +DISPLAY_BPP=16
> > > +DISPLAY_DPI=150
> > > +#DISPLAY_SUBPIXEL_ORDER=vrgb
> > > -- 
> > > 2.4.0
> > > 
> > > -- 
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > 
> > -- 
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> 
> Best Regards,
> Maxin
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]