Re: [PATCH 00/15] Prepare for EXTRA_OEMAKE = "" in bitbake.conf

[Olof Johansson <olof.johansson@axis.com>]

On 16-02-08 11:49 +0000, Burton, Ross wrote:
> On 5 February 2016 at 18:04, Mike Crowe <mac@mcrowe.com> wrote:
> 
> > This series (sent only to openembedded-core) fixes various recipes
> > that rely on the current default value of
> > EXTRA_OEMAKE = "-e MAKEFLAGS=" to explicitly set that value in the
> > hope that bitbake.conf can set EXTRA_OEMAKE = "" in the future.
> >
> 
> We need to also vet all instances of EXTRA_OEMAKE in recipes.  I did a
> build with the EXTRA_OEMAKE change in bitbake.conf and hdparm failed to
> pass QA because the binary was already stripped, as the recipe does
> EXTRA_OEMAKE += "STRIP=echo".  That assignment isn't getting through to the
> makefiles without -e.

It should though, since all -e does is to make the environment
variables take precedence over make assignments. But in case of
assignments in EXTRA_OEMAKE, they are make assignments, so they
shouldn't be affected:

$ cat Makefile
FOO = bar

all:
        echo $(FOO)

.PHONY: all


$ make FOO=qux
echo qux
qux
$ make -e FOO=qux
echo qux
qux
$ FOO=qux make
echo bar
bar
$ FOO=qux make -e
echo qux
qux


-- 
olofjn