Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Christopher Larson <chris_larson@mentor.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: don't throw away our created swap partition
Date: Mon, 29 Feb 2016 17:11:06 +0200	[thread overview]
Message-ID: <20160229151106.GA3674@linux.intel.com> (raw)
In-Reply-To: <1456420909-9926-1-git-send-email-kergoth@gmail.com>

Hi Cristopher,

Thank you for the patch!

Acked-by: Ed Bartosh <ed.bartosh@linux.intel.com>

On Thu, Feb 25, 2016 at 10:21:49AM -0700, Christopher Larson wrote:
> From: Christopher Larson <chris_larson@mentor.com>
> 
> We were creating the partition, mkswap'ing it, and then not dd'ing it into
> place in the final image, as source_file wasn't being set for swap partitions.
> This would result in a swap partition that couldn't be enabled on target until
> mkswap was run.
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  scripts/lib/wic/kickstart/custom_commands/partition.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/lib/wic/kickstart/custom_commands/partition.py b/scripts/lib/wic/kickstart/custom_commands/partition.py
> index eee25a4..a0e74aa 100644
> --- a/scripts/lib/wic/kickstart/custom_commands/partition.py
> +++ b/scripts/lib/wic/kickstart/custom_commands/partition.py
> @@ -173,6 +173,7 @@ class Wic_PartData(FC4_PartData):
>              if self.fstype and self.fstype == "swap":
>                  self.prepare_swap_partition(cr_workdir, oe_builddir,
>                                              native_sysroot)
> +                self.source_file = "%s/fs.%s" % (cr_workdir, self.fstype)
>              elif self.fstype:
>                  rootfs = "%s/fs_%s.%s.%s" % (cr_workdir, self.label,
>                                               self.lineno, self.fstype)
> -- 
> 2.2.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
--
Regards,
Ed


  reply	other threads:[~2016-02-29 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 17:21 [PATCH] wic: don't throw away our created swap partition Christopher Larson
2016-02-29 15:11 ` Ed Bartosh [this message]
2016-07-13  8:01   ` Francois Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229151106.GA3674@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=chris_larson@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox