From: Martin Jansa <martin.jansa@gmail.com>
To: Chris Trobridge <christrobridge@hotmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [oe] [PATCH] gpsd: Fix build when static libs disabled
Date: Tue, 1 Mar 2016 09:18:17 +0100 [thread overview]
Message-ID: <20160301081817.GA16002@jama> (raw)
In-Reply-To: <DUB130-W36E2C873DA9A2A4B6B6A73DABB0@phx.gbl>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
On Tue, Mar 01, 2016 at 07:58:14AM +0000, Chris Trobridge wrote:
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106230.html
>
> > Fix this build error:
> > SCons Error: no such option: --disable-static
> > Signed-off-by: Maxin B. John <maxin.john at intel.com>
> > ---
> > meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 1 +
> > 1 file changed, 1 insertion(+)
> > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > index ff268b3..a300595 100644
> > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > @@ -47,6 +47,7 @@ EXTRA_OESCONS = " \
> > systemd='${SYSTEMD_OESCONS}' \
> > ${EXTRA_OECONF} \
> > "
> > +DISABLE_STATIC = ""
> > & this cannot be used, because then chrpath is not found and only static lib is built
> > & target=${HOST_SYS}
> >
> > --
> > 2.4.0
>
> While this fixes the build, is it just fixing the symptom?
>
> I have a patch that copies the fix in:
>
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106251.html
>
> That is: use EXTRA_CONF_PACKAGECONFIG instead of EXTRA_OECONF, as mentioned the above diff.
>
> This prevents the option being pulled in in the first place, which ought to be a more general solution.
Both changes depend on RFC patch from me:
http://patchwork.openembedded.org/patch/116719/
which wasn't commented on yet or merged to at least master-next.
Regards,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
prev parent reply other threads:[~2016-03-01 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 7:58 [oe] [PATCH] gpsd: Fix build when static libs disabled Chris Trobridge
2016-03-01 8:00 ` Chris Trobridge
2016-03-01 8:18 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301081817.GA16002@jama \
--to=martin.jansa@gmail.com \
--cc=christrobridge@hotmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox