From: Martin Jansa <martin.jansa@gmail.com>
To: Ming Liu <liu.ming50@gmail.com>
Cc: yue.tao@windriver.com,
Peter Liu <peter.x.liu@external.atlascopco.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v1] libmad: avoid using legacy _thumb overrides
Date: Wed, 23 Mar 2016 15:41:07 +0100 [thread overview]
Message-ID: <20160323144107.GD2565@jama> (raw)
In-Reply-To: <1458742798-9890-1-git-send-email-liu.ming50@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]
On Wed, Mar 23, 2016 at 03:19:58PM +0100, Ming Liu wrote:
> From: Peter Liu <peter.x.liu@external.atlascopco.com>
>
> _thumb had been dropped from overrides since commit 351443d7:
> [ feature-arm-thumb.inc: drop legacy _thumb and _thumb-interwork over-rides ]
>
> Change to set EXTRA_OECONF_append by checking ARM_INSTRUCTION_SET instead.
This also isn't right, ARM_INSTRUCTION_SET can be set to "thumb" even
when MACHINE doesn't support it by having "thumb" in TUNE_FEATURES.
You'll need to replicate the conditionals which were used in the tune
files or just revert that cleanup if you find "thumb" override still
useful.
> [YOCTO #9323]
>
> Signed-off-by: Peter Liu <peter.x.liu@external.atlascopco.com>
> ---
> meta/recipes-multimedia/libmad/libmad_0.15.1b.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> index 9e08b16..4c15db2 100644
> --- a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> +++ b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> @@ -27,7 +27,7 @@ inherit autotools pkgconfig
>
> EXTRA_OECONF = "-enable-speed --enable-shared"
> # The ASO's don't take any account of thumb...
> -EXTRA_OECONF_append_thumb = " --disable-aso --enable-fpm=default"
> +EXTRA_OECONF_append = " ${@['', '--disable-aso --enable-fpm=default'][d.getVar('ARM_INSTRUCTION_SET', True) == 'thumb']}"
> EXTRA_OECONF_append_arm = " --enable-fpm=arm"
>
> do_configure_prepend () {
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2016-03-23 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 14:19 [PATCH v1] libmad: avoid using legacy _thumb overrides Ming Liu
2016-03-23 14:41 ` Martin Jansa [this message]
[not found] ` <DB3PR03MB201ABA2E63F24B74C089EACE3820@DB3PR03MB201.eurprd03.prod.outlook.com>
2016-03-24 14:50 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323144107.GD2565@jama \
--to=martin.jansa@gmail.com \
--cc=liu.ming50@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.x.liu@external.atlascopco.com \
--cc=yue.tao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox