From: Denys Dmytriyenko <denis@denix.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] coreutils: fix for native and nativesdk
Date: Tue, 26 Apr 2016 10:34:25 -0400 [thread overview]
Message-ID: <20160426143425.GF31113@denix.org> (raw)
In-Reply-To: <c53c41d6a33a354b8030e5a4b325aeb2753e9258.1461650616.git.liezhi.yang@windriver.com>
On Mon, Apr 25, 2016 at 11:04:37PM -0700, Robert Yang wrote:
> From: Dengke Du <dengke.du@windriver.com>
>
> The do_install_append is used for moving/renaming for ALTERNATIVE, but
> it breaks native, for example there is no ln, but ln.coreutils, that
> makes coreutils-native don't work. This patch fixes the problem.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/recipes-core/coreutils/coreutils_8.25.bb | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.25.bb b/meta/recipes-core/coreutils/coreutils_8.25.bb
> index 419a693..77b3862 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.25.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.25.bb
> @@ -70,6 +70,11 @@ do_compile_prepend () {
> }
>
> do_install_append() {
> + if [ "${CLASSOVERRIDE}" = "class-native" ]; then
> + rm -f ${D}${STAGING_BINDIR_NATIVE}/groups
> + return
> + fi
Would that skip the rest of do_install_append() for class-native due to the
return call? Is it expected?
> for i in df mktemp base64; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${BPN}; done
>
> install -d ${D}${base_bindir}
> @@ -91,11 +96,6 @@ do_install_append() {
> cp -a ${D}${mandir}/man1/test.1 ${D}${mandir}/man1/lbracket.1.${BPN}
> }
>
> -do_install_append_class-native(){
> - # remove groups to fix conflict with shadow-native
> - rm -f ${D}${STAGING_BINDIR_NATIVE}/groups
> -}
> -
> inherit update-alternatives
>
> ALTERNATIVE_PRIORITY = "100"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2016-04-26 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 6:04 [PATCH 0/1] coreutils: fix for native and nativesdk Robert Yang
2016-04-26 6:04 ` [PATCH 1/1] " Robert Yang
2016-04-26 14:34 ` Denys Dmytriyenko [this message]
2016-04-26 16:42 ` Khem Raj
2016-04-27 1:10 ` Robert Yang
2016-05-16 1:39 ` [PATCH 0/1] " Robert Yang
-- strict thread matches above, loose matches on Subject: below --
2015-10-10 7:04 Robert Yang
2015-10-10 7:04 ` [PATCH 1/1] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426143425.GF31113@denix.org \
--to=denis@denix.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox