Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 09/45] python3: manipulate all of the config*/Makefile files, not just config/Makefile
Date: Tue, 24 May 2016 14:50:02 +0200	[thread overview]
Message-ID: <20160524125002.GA2566@jama> (raw)
In-Reply-To: <caaf69df34a94f81e3aa5f853580cc59dacd6577.1464088997.git.alexander.kanavin@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

On Tue, May 24, 2016 at 02:53:58PM +0300, Alexander Kanavin wrote:
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
> ---
>  meta/recipes-devtools/python/python3_3.5.1.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-devtools/python/python3_3.5.1.bb b/meta/recipes-devtools/python/python3_3.5.1.bb
> index 26d05c7..1c8fe2f 100644
> --- a/meta/recipes-devtools/python/python3_3.5.1.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.1.bb
> @@ -164,6 +164,7 @@ do_install() {
>  	rm -f ${D}/${bindir}/2to3
>  
>  	install -m 0644 Makefile.sysroot ${D}/${libdir}/python${PYTHON_MAJMIN}/config/Makefile
> +	install -m 0644 Makefile.sysroot ${D}/${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}m/Makefile

Shouldn't it use "PYTHON_ABI" variable instead of "m"?

>  	if [ -e ${WORKDIR}/sitecustomize.py ]; then
>  		install -m 0644 ${WORKDIR}/sitecustomize.py ${D}/${libdir}/python${PYTHON_MAJMIN}
> @@ -182,9 +183,11 @@ PACKAGE_PREPROCESS_FUNCS += "py_package_preprocess"
>  py_package_preprocess () {
>  	# copy back the old Makefile to fix target package
>  	install -m 0644 ${B}/Makefile.orig ${PKGD}/${libdir}/python${PYTHON_MAJMIN}/config/Makefile

Shouldn't it use "PYTHON_ABI" variable instead of "m"?

> +	install -m 0644 ${B}/Makefile.orig ${PKGD}/${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}m/Makefile
>  	# Remove references to buildmachine paths in target Makefile and _sysconfigdata
>  	sed -i -e 's:--sysroot=${STAGING_DIR_TARGET}::g' -e s:'--with-libtool-sysroot=${STAGING_DIR_TARGET}'::g \
>  		${PKGD}/${libdir}/python${PYTHON_MAJMIN}/config/Makefile \
> +		${PKGD}/${libdir}/python${PYTHON_MAJMIN}/config-${PYTHON_MAJMIN}m/Makefile \

Shouldn't it use "PYTHON_ABI" variable instead of "m"?

>  		${PKGD}/${libdir}/python${PYTHON_MAJMIN}/_sysconfigdata.py
>  }
>  
> -- 
> 2.8.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2016-05-24 12:49 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 11:53 [PATCH 00/45] Move recipes to use Python 3 whenever possible Alexander Kanavin
2016-05-24 11:53 ` [PATCH 01/45] python-native, python3-native: remove the use of exported HOST_SYS and BUILD_SYS variables Alexander Kanavin
2016-05-24 11:53 ` [PATCH 02/45] distutils-native-base.bbclass, distutils3-native-base.bbclass: remove Alexander Kanavin
2016-05-24 11:53 ` [PATCH 03/45] python3-dir.bbclass: add a separate class for Python 3 Alexander Kanavin
2016-05-24 11:53 ` [PATCH 04/45] default-versions.inc: drop python-related defaults Alexander Kanavin
2016-05-24 11:53 ` [PATCH 05/45] sip.bbclass: remove Alexander Kanavin
2016-05-24 16:35   ` Philip Balister
2016-05-25 12:41     ` alexander.kanavin
2016-05-24 11:53 ` [PATCH 06/45] avahi-ui: remove support for building a python module Alexander Kanavin
2016-05-24 11:53 ` [PATCH 07/45] bind: switch Python dependency to Python 3.x Alexander Kanavin
2016-05-24 11:53 ` [PATCH 08/45] python-dbus: update to 1.2.4, port to python 3 Alexander Kanavin
2016-05-24 11:53 ` [PATCH 09/45] python3: manipulate all of the config*/Makefile files, not just config/Makefile Alexander Kanavin
2016-05-24 12:50   ` Martin Jansa [this message]
2016-05-25 12:37     ` alexander.kanavin
2016-05-24 11:53 ` [PATCH 10/45] python3: drop 110-enable-zlib.patch Alexander Kanavin
2016-05-24 11:54 ` [PATCH 11/45] glib: move to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 12/45] dbus-test: remove unneeded pygobject dependency Alexander Kanavin
2016-05-24 11:54 ` [PATCH 13/45] python-pygobject: port to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 14/45] neard: do not package python test scripts Alexander Kanavin
2016-05-24 11:54 ` [PATCH 15/45] bluez5: switch to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 16/45] connman: do not install Python test scripts Alexander Kanavin
2016-05-24 11:54 ` [PATCH 17/45] ofono: drop the custom-made revert to Python 2 from Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 18/45] packagegroup-core-full-cmdline: drop python-dbus from the list of services Alexander Kanavin
2016-05-24 11:54 ` [PATCH 19/45] nfs-utils: switch to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 20/45] systemd: drop python dependency for ptests Alexander Kanavin
2016-05-24 11:54 ` [PATCH 21/45] util-linux: move to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 22/45] python-pycairo: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 23/45] bootchart2: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 24/45] gdb: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 25/45] git: remove Python package (to which nothing was packaged) Alexander Kanavin
2016-05-24 11:54 ` [PATCH 26/45] qemu: remove runtime python dependency Alexander Kanavin
2016-05-24 11:54 ` [PATCH 27/45] subversion: remove unnecessary " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 28/45] swig: move to Python 3 Alexander Kanavin
2016-05-24 16:38   ` Philip Balister
2016-05-25 12:45     ` alexander.kanavin
2016-05-25 14:24       ` Philip Balister
2016-05-26 10:05         ` alexander.kanavin
2016-05-27 13:21       ` Mike Looijmans
2016-05-30  9:06         ` Alexander Kanavin
2016-05-24 11:54 ` [PATCH 29/45] python-pyrex: remove unused recipe Alexander Kanavin
2016-05-24 11:54 ` [PATCH 30/45] python-imaging: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 31/45] python-docutils: move to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 32/45] cracklib: disable building the python module Alexander Kanavin
2016-05-24 11:54 ` [PATCH 33/45] libuser: move to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 34/45] libnewt-python: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 35/45] gnome-doc-utils: remove recipe Alexander Kanavin
2016-05-24 11:54 ` [PATCH 36/45] lttng-tools: move to Python 3 Alexander Kanavin
2016-05-24 11:54 ` [PATCH 37/45] lttng-ust: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 38/45] systemtap: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 39/45] libcap-ng: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 40/45] hwlatdetect: " Alexander Kanavin
2016-05-24 11:54 ` [PATCH 41/45] python3-mako: add a Python 3 recipe Alexander Kanavin
2016-05-24 11:54 ` [PATCH 42/45] python3-nose: add a recipe Alexander Kanavin
2016-05-24 11:54 ` [PATCH 43/45] python3: add = to -L linking option only when the path is absolute Alexander Kanavin
2016-05-24 11:54 ` [PATCH 44/45] python-numpy: move recipe to own directory Alexander Kanavin
2016-05-24 11:54 ` [PATCH 45/45] python3-numpy: add a recipe Alexander Kanavin
2016-05-24 20:59 ` [PATCH 00/45] Move recipes to use Python 3 whenever possible Mark Hatle
2016-05-25 13:01   ` alexander.kanavin
2016-05-25 13:47     ` alexander.kanavin
2016-05-26 13:39     ` Mark Hatle
2016-05-26 13:49       ` Alexander Kanavin
2016-05-26 14:02         ` Mark Hatle
2016-05-31  7:44 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524125002.GA2566@jama \
    --to=martin.jansa@gmail.com \
    --cc=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox