Re: [oe-commits] [openembedded-core] 09/12: classes/insane: do not force LIC_FILES_CHKSUM unless SRC_URI is set

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 6700 bytes --]

On Wed, May 11, 2016 at 09:35:05AM +0000, git@git.openembedded.org wrote:
> rpurdie pushed a commit to branch master
> in repository openembedded-core.
> 
> commit c269547ae8e90a78349f6003385137e4145e145f
> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
> AuthorDate: Tue May 10 10:25:05 2016 +1200
> 
>     classes/insane: do not force LIC_FILES_CHKSUM unless SRC_URI is set
>     
>     Recipes such as images and packagegroups don't actually fetch or build
>     any source, so there's really no point having LIC_FILES_CHKSUM set.
>     Forcing users to set it (as we have done for images inheriting
>     image.bbclass) just makes things more difficult for the user for no
>     discernable benefit. The easiest way to adjust this check is simply to
>     skip it if SRC_URI is not set since this is a pretty good indicator that
>     no source is being pulled in.

I'm not sure which recent change caused it, but can we keep the QA issues
stored in qa.log to contain all important information on single line
which ends with [check-name]? (it can have more details on preceeding lines
like installed-not-packaged check)

The qa.log from last world build is missing many line-feeds and
[license-checksum] are hard to read (even worse to parse automatically)

see:
http://logs.nslu2-linux.org/buildlogs/oe/world//log.world.qemuarm.20160523_030221.log//qa.log

libnewt-0.52.18: /usr/bin/whiptail contained in package whiptail requires libnewt.so, but no providers found in RDEPENDS_whiptail? [file-rdeps]qtwayland-5.6.99+5.7.0-beta+gitAUTOINC+d27075a3f9: qtwayland-plugins rdepends on libxcomposite, but it isn't a build dependency, missing libxcomposite in DEPENDS or PACKAGECONFIG? [build-deps]gnome-menus-2.30.5: /usr/bin/gmenu-simple-editor contained in package gnome-menus requires /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/x86_64-linux/usr/bin/python-native/python, but no providers found in RDEPENDS_gnome-menus? [file-rdeps]networkmanager-1.0.10: /usr/bin/nmtui-connect contained in package networkmanager-nmtui requires libnewt.so, but no providers found in RDEPENDS_networkmanager-nmtui? [file-rdeps]samba-4.4.2: samba rdepends on libpam, but it isn't a build dependency, missing libpam in DEPENDS or PACKAGECONFIG? [build-deps]xfsprogs-3.2.3: /usr/sbin/xfs_db contained in package xfsprogs requires libxfs.so.0, but no providers found in RDEPENDS_xfsprogs? [file-rdeps]xfsprogs-3.2.3: /sbin/mkfs.xfs contained in package xfsprogs-mkfs requires libxfs.so.0, but no providers found in RDEPENDS_xfsprogs-mkfs? [file-rdeps]chkconfig-1.3.58: /usr/sbin/ntsysv contained in package chkconfig requires libnewt.so, but no providers found in RDEPENDS_chkconfig? [file-rdeps]numptyphysics-0.2+svnr109: /usr/share/numptyphysics/convert_all.sh contained in package numptyphysics requires /bin/bash, but no providers found in RDEPENDS_numptyphysics? [file-rdeps]qtcharts-5.6.99+5.7.0-beta+gitAUTOINC+8a78184181: qtcharts-examples rdepends on qtmultimedia, but it isn't a build dependency, missing qtmultimedia in DEPENDS or PACKAGECONFIG? [build-deps]libmodule-build-perl-0.31: /usr/bin/config_data contained in package libmodule-build-perl requires /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/x86_64-linux/usr/bin/perl-native/perl.real, but no providers found in RDEPENDS_libmodule-build-perl? [file-rdeps]dvb-apps-1.1.1: /usr/bin/dvbdate contained in package dvbdate requires libucsi.so, but no providers found in RDEPENDS_dvbdate? [file-rdeps]dvb-apps-1.1.1: /usr/bin/dvbtraffic contained in package dvbtraffic requires libdvbapi.so, but no providers found in RDEPENDS_dvbtraffic? [file-rdeps]dvb-apps-1.1.1: /usr/bin/dvbscan contained in package dvb-scan requires libdvbapi.so, but no providers found in RDEPENDS_dvb-scan? [file-rdeps]dvb-apps-1.1.1: /usr/bin/gotox contained in package dvb-apps requires libdvbapi.so, but no providers found in RDEPENDS_dvb-apps? [file-rdeps]dvb-apps-1.1.1: /usr/bin/femon contained in package dvb-femon requires libdvbapi.so, but no providers found in RDEPENDS_dvb-femon? [file-rdeps]dvb-apps-1.1.1: /usr/bin/dvbnet contained in package dvbnet requires libdvbapi.so, but no providers found in RDEPENDS_dvbnet? [file-rdeps]libnewt-python-0.52.18: /usr/lib/python2.7/site-packages/_snack.so contained in package libnewt-python requires libnewt.so, but no providers found in RDEPENDS_libnewt-python? [file-rdeps]packagegroup-tools-bluetooth-1.0: packagegroup-tools-bluetooth: The LIC_FILES_CHKSUM does not match for file:///home/jenkins/oe/world/shr-core/openembedded-core/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58
packagegroup-tools-bluetooth: The new md5 checksum is 4d92cd373abda3937c2bc47fbc49d690
packagegroup-tools-bluetooth: Check if the license information has changed in /home/jenkins/oe/world/shr-core/openembedded-core/LICENSE to verify that the LICENSE value "MIT" remains valid [license-checksum]ubx-utils-0.0.0+gitrAUTOINC+b63c0932dd: /usr/bin/memory-map.sh contained in package ubx-utils requires /bin/bash, but no providers found in RDEPENDS_ubx-utils? [file-rdeps]

>     Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/insane.bbclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 097dc3a..0b151c2 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -681,15 +681,15 @@ python populate_lic_qa_checksum() {
>      import tempfile
>      sane = True
>  
> -    lic_files = d.getVar('LIC_FILES_CHKSUM', True)
> +    lic_files = d.getVar('LIC_FILES_CHKSUM', True) or ''
>      lic = d.getVar('LICENSE', True)
>      pn = d.getVar('PN', True)
>  
>      if lic == "CLOSED":
>          return
>  
> -    if not lic_files:
> -        package_qa_handle_error("license-checksum", pn + ": Recipe file does not have license file information (LIC_FILES_CHKSUM)", d)
> +    if not lic_files and d.getVar('SRC_URI', True):
> +        package_qa_handle_error("license-checksum", pn + ": Recipe file fetches files and does not have license file information (LIC_FILES_CHKSUM)", d)
>          return
>  
>      srcdir = d.getVar('S', True)
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]