Re: [PATCHv2 0/2] Support template files for wic

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Fri, Jul 01, 2016 at 02:27:00PM -0700, Christopher Larson wrote:
> From: Christopher Larson <chris_larson@mentor.com>
> 
> This adds support for .wks.in files as WKS_FILE.
> 
> This is a re-send of the RFC PATCH series as a regular PATCH series, to
> attempt to get the feature merged. There's a clear value-add, there were no
> major objections to the RFC series, and further improvements can be added on
> from here.
> 
> These files are treated as the contents of a bitbake variable, so usual
> bitbake variable references are supported. I considered using another
> templating mechanism, for example the one used by yocto-layer, but then we'd
> end up largely mapping metadata variables to template fields anyway, which is
> a pointless indirection. Let bitbake expand the variables directly instead.
> 
> This feature lets us, for example, reference ${APPEND} in --append, and avoid
> hardcoding the serial console tty in the wks file, and let the user's changes
> to APPEND affect wic the way they do the other image construction mechanisms.
> 
> The template is read in and set in a variable at parse time, so changes to the
> variables referenced by the template will result in rebuilding the image.
> 
> 
> The following changes since commit 646c366c2566bd8dd6f73681cea9f5b021589a56:
> 
>   gst-player: upgrade to latest HEAD (2016-06-27 14:08:37 +0100)
> 
> are available in the git repository at:
> 
>   git://github.com/kergoth/openembedded-core wks.in2
>   https://github.com/kergoth/openembedded-core/tree/wks.in2
> 
> Christopher Larson (2):
>   image_types.bbclass: add intermediate var for WKS_FILE_CHECKSUM
>   image_types.bbclass: support template .wks.in files for wic
> 
>  meta/classes/image_types.bbclass | 49 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 

Thank you for the patchset!

A bit unrelated note. You seem to know wic functionality in meta/classes/image* better
than anyone else. Would you mind adding this knowledge to wic documentation in development manual?

--
Regards,
Ed