Re: [PATCH] wget: Add --ssh-askpass support

["Liam R. Howlett" <Liam.Howlett@windriver.com>]

* Burton, Ross <ross.burton@intel.com> [160726 09:38]:
> On 22 July 2016 at 19:24, Liam R. Howlett <Liam.Howlett@windriver.com>
> wrote:
> 
> > diff --git a/meta/recipes-extended/wget/wget/0001-wget-Add-ssh-askpass-support.patch
> > b/meta/recipes-extended/wget/wget/0001-wget-Add-ssh-askpass-support.patch
> > new file mode 100644
> > index 0000000..e402375
> > --- /dev/null
> > +++ b/meta/recipes-extended/wget/wget/0001-wget
> > -Add-ssh-askpass-support.patch
> > [snip]
> >
> 
> 
> > diff --git a/meta/recipes-extended/wget/wget_1.18.bb
> > b/meta/recipes-extended/wget/wget_1.18.bb
> > index c969b98..20ec503 100644
> > --- a/meta/recipes-extended/wget/wget_1.18.bb
> > +++ b/meta/recipes-extended/wget/wget_1.18.bb
> > @@ -1,5 +1,6 @@
> >  SRC_URI = "${GNU_MIRROR}/wget/wget-${PV}.tar.gz \
> >
> > file://0001-Unset-need_charset_alias-when-building-for-musl.patch \
> > +           file://0001-Add-ssh-askpass-support.patch \
> 
> 
> As the patch and the SRC_URI don't match, this patch clearly hasn't been
> tested.
> 

Apologies for the SRC_URI mismatch.  I had tested my patch but during my
development, I clarified my commit message which changed the filename.
I did not update the include file SRC_URI and had left the old file in
place while I tested.  I will resend a new version as soon as upstream
is happy.

> Also if you're working with upstream then please change the Upstream-Status
> to Submitted and provide a link (mailing list post, bug entry, whatever).

There was a question as to where to send the patch and I wanted to get
your input for new revisions as well.  I will update the status with a
link on the next revision.

I appreciate your input.

Thanks,
Liam

> 
> Ross