public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: add lzop dependency
Date: Fri, 5 Aug 2016 10:24:58 -0400	[thread overview]
Message-ID: <20160805142458.GA16924@openSUSE-i7.site> (raw)
In-Reply-To: <CADkTA4NvDf+Wo8fSGiRGirE74z7Bi8EjmFeK-opz=sUzMJLsNw@mail.gmail.com>

On Wed 2016-08-03 @ 09:39:59 PM, Bruce Ashfield wrote:
> On Wed, Aug 3, 2016 at 8:53 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> 
> > On Mon 2016-08-01 @ 03:08:36 PM, Burton, Ross wrote:
> > > On 1 August 2016 at 15:07, Bruce Ashfield <bruce.ashfield@gmail.com>
> > wrote:
> > >
> > > > Not a large dependency, but it does bring to mind the question if this
> > > > could be conditional on the type of image being built ? via  distro
> > > > feature, some other mechanism ?
> > > >
> > >
> > > Exactly this: image building adds dependencies automatically based on
> > what
> > > is actually being used, so can the kernel do this too?
> >
> > The way the build knows which image was built is to build the kernel then
> > look
> > in the output directory to see what extension was given to the artifact.
> > iow,
> > it only discovers the dependency partway through the build; it doesn't know
> > the dependency when the build starts.
> >
> > Either bitbake will have to put together the kernel's config at the start
> > of
> > the build, then parse through it to try to determine which kernel will be
> > built, or we need some sort of mechanism that allows us to add dependencies
> > partway through a build, or we can add (yet another) build variable and
> > hope
> > people are able to keep it in sync.
> >
> >
> I'm on vacation for the next two weeks, so sorry for the slow reply.

np enjoy! "'tis the season" :-)

> 
> Wouldn't something like PACKAGECONFIG work here ? Something automatic
> is going to be complex (like you describe), but something like this would
> be an
> easy way for a BSP (or other) layer to bbappend the kernel and add this as
> a dependency.
> 
> ... but then again, I suppose they could currently just bbappend the kernel
> recipe
> and add it directly to the DEPENDS.

I've proposed a change to the kernel.bbclass to add the lzop-native DEPENDS to
the existing

	DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross bc-native"

because it's in this file that the lzop program is being called.

It seems as though your suggestions are discussing changes to a recipe (?)
which is fine, I'll propose a patch to the BSP-in-question's kernel recipe.

> 
> >
> > ...or we could just add lzop-native as a static dependency in the
> > off-chance that
> > it's needed.
> >
> 
> 
> 
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"


  reply	other threads:[~2016-08-05 14:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 12:32 [PATCH] kernel.bbclass: add lzop dependency Trevor Woerner
2016-08-01 14:07 ` Bruce Ashfield
2016-08-01 14:08   ` Burton, Ross
2016-08-02 13:52     ` Trevor Woerner
2016-08-03 12:53     ` Trevor Woerner
2016-08-04  1:39       ` Bruce Ashfield
2016-08-05 14:24         ` Trevor Woerner [this message]
2016-08-09 12:08 ` Mike Looijmans
2016-08-09 19:27   ` Khem Raj
2016-08-10  8:59     ` Richard Purdie
2016-08-10 16:07       ` Khem Raj
2016-08-10 16:46         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805142458.GA16924@openSUSE-i7.site \
    --to=twoerner@gmail.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox