From: Denys Dmytriyenko <denis@denix.org>
To: George McCollister <george.mccollister@gmail.com>
Cc: marex@denx.de, trini@konsulko.com, denys@ti.com,
andrew.bradford@kodakalaris.com,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/5] kernel-fitimage.bbclass: do_assemble_fitimage(): cd to $B
Date: Mon, 08 Aug 2016 17:30:57 -0400 [thread overview]
Message-ID: <20160808213055.GQ8521@denix.org> (raw)
In-Reply-To: <da75f7dd900ec6188699011a2d49ca8afbaffefb.1470672689.git.george.mccollister@gmail.com>
On Mon, Aug 08, 2016 at 11:37:53AM -0500, George McCollister wrote:
> From: Andrew Bradford <andrew.bradford@kodakalaris.com>
>
> Prior to assembling the fitimage, ensure that $B is the cwd due to
> bitbake commit 67a7b8b021badc17d8fdf447c250e79d291e75f7 "build: don't
> use $B as the default cwd for functions".
>
> Without this change, do_assemble_fitimage() fails like:
>
> Log data follows:
> | DEBUG: Executing shell function do_assemble_fitimage
> | arm-ka-linux-gnueabi-objcopy: 'vmlinux': No such file
> | WARNING: exit code 1 from a shell command.
> | ERROR: Function failed: do_assemble_fitimage
>
> Signed-off-by: Andrew Bradford <andrew.bradford@kodakalaris.com>
Tested-by: Denys Dmytriyenko <denys@ti.com>
Acked-by: Denys Dmytriyenko <denys@ti.com>
> ---
> meta/classes/kernel-fitimage.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 9a3caf5..7cca180 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -189,6 +189,7 @@ EOF
> }
>
> do_assemble_fitimage() {
> + cd ${B}
> if echo ${KERNEL_IMAGETYPES} | grep -wq "fitImage"; then
> kernelcount=1
> dtbcount=""
> --
> 2.8.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2016-08-08 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:37 [PATCH v2 0/5] kernel-fitimage: Add initramfs, x86 support George McCollister
2016-08-08 16:37 ` [PATCH 1/5] kernel-fitimage.bbclass: do_assemble_fitimage(): cd to $B George McCollister
2016-08-08 21:30 ` Denys Dmytriyenko [this message]
2016-08-08 16:37 ` [PATCH v3 2/5] kernel-fitimage: add initramfs support George McCollister
2016-08-08 21:31 ` Denys Dmytriyenko
2016-08-08 16:37 ` [PATCH v2 3/5] kernel-fitimage: Add x86 support George McCollister
2016-08-08 16:37 ` [PATCH v2 4/5] uboot-sign: Handle .rom signing the same as .img George McCollister
2016-08-08 16:37 ` [PATCH 5/5] uboot-sign: do_concat_dtb(): cd to $B George McCollister
2016-08-08 21:32 ` Denys Dmytriyenko
2016-08-08 18:05 ` [PATCH v2 0/5] kernel-fitimage: Add initramfs, x86 support Denys Dmytriyenko
2016-08-08 20:02 ` Burton, Ross
2016-08-08 20:16 ` George McCollister
2016-08-08 20:21 ` Burton, Ross
2016-08-08 21:34 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808213055.GQ8521@denix.org \
--to=denis@denix.org \
--cc=andrew.bradford@kodakalaris.com \
--cc=denys@ti.com \
--cc=george.mccollister@gmail.com \
--cc=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox