From: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
To: openembedded-core@lists.openembedded.org
Cc: yocto@yoctoproject.org
Subject: [yocto-kernel-tools][PATCH] merge_configs.sh: fail loudly if make also fails
Date: Mon, 29 Aug 2016 12:19:05 +0300 [thread overview]
Message-ID: <20160829091905.1068-1-adrian.ratiu@ni.com> (raw)
merge_configs.sh calls make on the generated kernel config from
the defconfig + fragments to fill in any missing symbols. make
can fail and this can lead to nasty errors further on in the
build like generating an unbootable kernel image.
Check the make return code and fail loudly if non-zero.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
tools/merge_config.sh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/merge_config.sh b/tools/merge_config.sh
index 67d1314..5212f37 100755
--- a/tools/merge_config.sh
+++ b/tools/merge_config.sh
@@ -152,7 +152,10 @@ fi
# alldefconfig: Fills in any missing symbols with Kconfig default
# allnoconfig: Fills in any missing symbols with # CONFIG_* is not set
make KCONFIG_ALLCONFIG=$TMP_FILE $OUTPUT_ARG $ALLTARGET
-
+if [ "$?" -ne 0 ]; then
+ echo "Make failed to fill missing config symbols. Exit." >&2
+ exit 1
+fi
# Check all specified config values took (might have missed-dependency issues)
for CFG in $(sed -n "$SED_CONFIG_EXP" $TMP_FILE); do
--
2.9.3
next reply other threads:[~2016-08-29 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 9:19 Ioan-Adrian Ratiu [this message]
2016-08-29 12:07 ` [yocto-kernel-tools][PATCH] merge_configs.sh: fail loudly if make also fails Bruce Ashfield
2016-08-29 12:55 ` [yocto] " Bruce Ashfield
2016-08-29 13:22 ` Ioan-Adrian Ratiu
2016-08-29 13:27 ` Bruce Ashfield
2016-08-29 13:09 ` Ioan-Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829091905.1068-1-adrian.ratiu@ni.com \
--to=adrian.ratiu@ni.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox