From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mail.openembedded.org (Postfix) with ESMTP id 0CB5673695 for ; Tue, 30 Aug 2016 11:22:11 +0000 (UTC) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 30 Aug 2016 04:22:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,256,1470726000"; d="scan'208";a="162431890" Received: from linux.intel.com ([10.54.29.200]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2016 04:22:11 -0700 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id C44296A4080; Tue, 30 Aug 2016 04:21:49 -0700 (PDT) Date: Tue, 30 Aug 2016 14:21:59 +0300 From: Ed Bartosh To: Otavio Salvador Message-ID: <20160830112159.GB3482@linux.intel.com> Reply-To: ed.bartosh@linux.intel.com References: <20160830103536.GA3482@linux.intel.com> MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 00/18] Provide list of deployment artifacts X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 11:22:12 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 30, 2016 at 07:58:31AM -0300, Otavio Salvador wrote: > On Tue, Aug 30, 2016 at 7:35 AM, Ed Bartosh wrote: > > On Tue, Aug 30, 2016 at 07:21:20AM -0300, Otavio Salvador wrote: > >> On Tue, Aug 30, 2016 at 6:29 AM, Ed Bartosh wrote: > >> > Hi, > >> > > >> > This is a fix for Bug #9869 - Provide a per-target manifest of files which were, or would have been, produced > >> > > >> > The list of artifacts produced by deployment tasks (do_deploy, do_image_complete and do_populate_sdk[_ext] is > >> > obtained from sstate manifests and fired as a TaskArtifacts metadata event. This should allow Toaster to > >> > handle artifacts in simple way and remove a lot of current Toaster code doing guess work. > >> > > >> > To generate manifests for do_image_complete and do_populate_sdk they have been put under sstate control. > >> > > >> > To avoid storing big files(images and sdk installer) in sstate new variable SSTATE_SKIP_CREATION has been > >> > set in image.bbclass and populate_sdk_base.bbclass and sstate code was modified to avoid adding files > >> > to sstate if SSTATE_SKIP_CREATION is set. > >> > >> SKIP creation of what? > > SKIP creation of SSTATE entity. > > I know but of WHAT? Of anything we don't want to put to sstate. In this patchset it's set for do_image_complete and do_populate_sdk, so it's for images and sdk installer. > SSTATE_SKIP_IMAGE_CREATION would be a clearer name for me. I'm not sure about it. I'd need one more variable SSTATE_SKIP_SDK_INSTALLER if I go this way. > >> Variable name seems a little vague for me. Even > >> needing the manifest, does it makes sense to store the image and SDK > >> on sstate? > > It doesn't and skipping this is a purpose of introducing SSTATE_SKIP_CREATION variable. > > So it is always going to be skipped? Yes it is for do_image_complete and do_populate_sdk tasks for now. -- Regards, Ed