From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 358AD60603 for ; Thu, 29 Sep 2016 00:59:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 7F50020901; Thu, 29 Sep 2016 00:59:28 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WISHmbrwcqnu; Thu, 29 Sep 2016 00:59:28 +0000 (UTC) Received: from gandalf.denix.org (pool-100-15-110-130.washdc.fios.verizon.net [100.15.110.130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 488F420068; Thu, 29 Sep 2016 00:59:24 +0000 (UTC) Received: by gandalf.denix.org (Postfix, from userid 1000) id CAF9316214C; Wed, 28 Sep 2016 20:59:23 -0400 (EDT) Date: Wed, 28 Sep 2016 20:59:23 -0400 From: Denys Dmytriyenko To: Richard Purdie Message-ID: <20160929005923.GA3771@denix.org> References: <1463990873.3095.13.camel@intel.com> <1463996105.9570.18.camel@linuxfoundation.org> MIME-Version: 1.0 In-Reply-To: <1463996105.9570.18.camel@linuxfoundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Olev Kartau , Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/5] useradd.bbclass: Strip trailing '; ' in cmd params X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 00:59:28 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 23, 2016 at 10:35:05AM +0100, Richard Purdie wrote: > On Mon, 2016-05-23 at 10:07 +0200, Patrick Ohly wrote: > > On Wed, 2016-05-18 at 12:38 -0700, Khem Raj wrote: > > > This fix was not sufficient and there has to be extra fix done to > > > also > > > consider the case > > > when sysroot is created during image build time. I have updated it > > > in > > > pull request here > > > > > > http://git.openembedded.org/openembedded-core-contrib/commit/?h=kra > > > j/pu&id=642c6cf0b6a0371de476513162bd0cefa9c438b3 > > > > That now fails for cases where the USERADD_PARAM ends in trailing > > white > > space after the last valid opts. The reason is that the 'if test "x > > $opts" = "x$remaining"; then break; fi' check does not get triggered > > anymore, because $remaining has the trailing white space whereas > > "$opts" > > does not. > > > > I'm not sure what the best approach is in this case. Perhaps also > > strip > > trailing whitespace from all assignments to $remaining? > > > > The case were we see this is: > > USERADD_PARAM_iot-rest-api-server="--system --home /var/lib/empty - > > -no-create-home --shell /bin/false --gid restful restful " > > > > The build then hangs because the useradd preinst loops forever. > > I've posted a patch which addresses this issue since its pretty nasty > for people to run into. This now has been merged to krogoth and I get vsftpd preinst hanging forever - has everything related been picked up during backport or something got missed? -- Denys