Re: [PATCH 1/5] useradd.bbclass: Strip trailing '; ' in cmd params

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Sep 28, 2016 at 09:07:19PM -0400, Denys Dmytriyenko wrote:
> On Wed, Sep 28, 2016 at 08:59:23PM -0400, Denys Dmytriyenko wrote:
> > On Mon, May 23, 2016 at 10:35:05AM +0100, Richard Purdie wrote:
> > > On Mon, 2016-05-23 at 10:07 +0200, Patrick Ohly wrote:
> > > > On Wed, 2016-05-18 at 12:38 -0700, Khem Raj wrote:
> > > > > This fix was not sufficient and there has to be extra fix done to
> > > > > also
> > > > > consider the case
> > > > > when sysroot is created during image build time. I have updated it
> > > > > in
> > > > > pull request here
> > > > > 
> > > > > http://git.openembedded.org/openembedded-core-contrib/commit/?h=kra
> > > > > j/pu&id=642c6cf0b6a0371de476513162bd0cefa9c438b3
> > > > 
> > > > That now fails for cases where the USERADD_PARAM ends in trailing
> > > > white
> > > > space after the last valid opts. The reason is that the 'if test "x
> > > > $opts" = "x$remaining"; then break; fi' check does not get triggered
> > > > anymore, because $remaining has the trailing white space whereas
> > > > "$opts"
> > > > does not.
> > > > 
> > > > I'm not sure what the best approach is in this case. Perhaps also
> > > > strip
> > > > trailing whitespace from all assignments to $remaining?
> > > > 
> > > > The case were we see this is:
> > > > USERADD_PARAM_iot-rest-api-server="--system --home /var/lib/empty -
> > > > -no-create-home --shell /bin/false --gid restful restful "
> > > > 
> > > > The build then hangs because the useradd preinst loops forever.
> > > 
> > > I've posted a patch which addresses this issue since its pretty nasty
> > > for people to run into.
> > 
> > This now has been merged to krogoth and I get vsftpd preinst hanging forever - 
> > has everything related been picked up during backport or something got missed?
> 
> Ok, it seems this change hasn't been picked up:
> 
> http://cgit.openembedded.org/openembedded-core/commit/meta/classes/useradd.bbclass?id=d6241e4c94a0a72acfc57e96a59918c0b2146d65

Ok, this fixes my problem with vsftpd - I sent a patch to backport this commit 
into krogoth.

-- 
Denys