[PATCH] systemtap: add dependency on boost

[PATCH] systemtap: add dependency on boost

[Martin Jansa]

* otherwise the build may fail with:
| ERROR: oe_runmake failed
| In file included from ../../git/staprun/../util.h:44:0,
|                  from ../../git/staprun/../util.cxx:17:
| ../../git/staprun/../stringtable.h:17:29: fatal error: boost/version.hpp: No such file or directory
|  #include <boost/version.hpp>
|                              ^
| compilation terminated.
| In file included from ../../git/staprun/../util.h:44:0,
|                  from ../../git/staprun/../privilege.cxx:23:
| ../../git/staprun/../stringtable.h:17:29: fatal error: boost/version.hpp: No such file or directory
|  #include <boost/version.hpp>
|                              ^
| compilation terminated.
| rm -f libstrfloctime.a

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-kernel/systemtap/systemtap_git.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-kernel/systemtap/systemtap_git.bb b/meta/recipes-kernel/systemtap/systemtap_git.bb
index da30fa5..15f0d4e 100644
--- a/meta/recipes-kernel/systemtap/systemtap_git.bb
+++ b/meta/recipes-kernel/systemtap/systemtap_git.bb
@@ -2,9 +2,9 @@ SUMMARY = "Script-directed dynamic tracing and performance analysis tool for Lin
 
 require systemtap_git.inc
 
-DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c"
-DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native"
-DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext"
+DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
+DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native boost-native"
+DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext nativesdk-boost"
 
 RDEPENDS_${PN} += "python3-core bash"
 
-- 
2.10.0

Re: [PATCH] systemtap: add dependency on boost

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

On 3 October 2016 at 18:14, Martin Jansa <martin.jansa@gmail.com> wrote:

> +DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
> +DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native
> boost-native"
> +DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3
> nativesdk-gettext nativesdk-boost"
>

So why does systemtap appear to have floating dependencies for ncurses and
json-c?  Should we be expressing this as a single DEPENDS line with
something like different PACKAGECONFIG for target/native?

Ross

[-- Attachment #2: Type: text/html, Size: 997 bytes --]

Re: [PATCH] systemtap: add dependency on boost

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

PACKAGECONFIG would be nice

I don't use systemtap, I've just noticed it failing in one of my world
builds after recent boost which probably remove native boost from sysroot
between systemtap's do_configure and do_compile and caused this failure.

On Tue, Oct 4, 2016 at 11:21 AM, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 3 October 2016 at 18:14, Martin Jansa <martin.jansa@gmail.com> wrote:
>
>> +DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
>> +DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native
>> boost-native"
>> +DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3
>> nativesdk-gettext nativesdk-boost"
>>
>
> So why does systemtap appear to have floating dependencies for ncurses and
> json-c?  Should we be expressing this as a single DEPENDS line with
> something like different PACKAGECONFIG for target/native?
>
> Ross
>

[-- Attachment #2: Type: text/html, Size: 1822 bytes --]

Re: [PATCH] systemtap: add dependency on boost

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On 4 October 2016 at 10:46, Martin Jansa <martin.jansa@gmail.com> wrote:

> PACKAGECONFIG would be nice
>
> I don't use systemtap, I've just noticed it failing in one of my world
> builds after recent boost which probably remove native boost from sysroot
> between systemtap's do_configure and do_compile and caused this failure.
>

Patch incoming that incorporates this.

Ross

[-- Attachment #2: Type: text/html, Size: 859 bytes --]