From: Martin Jansa <martin.jansa@gmail.com>
To: Kyle Russell <bkylerussell@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] pixbufcache: Ensure sysroot dependencies are satisfied
Date: Tue, 11 Oct 2016 20:29:33 +0200 [thread overview]
Message-ID: <20161011182933.GB2917@jama> (raw)
In-Reply-To: <1476195437-24040-1-git-send-email-bkylerussell@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2088 bytes --]
On Tue, Oct 11, 2016 at 10:17:16AM -0400, Kyle Russell wrote:
> Reverts part of b411085fefc8582d24c172db5f6610705eb44c2f
>
> Makes sure gdk-pixbuf-native populates the sysroot during setscene;
> otherwise, gdk-pixbuf-query-loaders may not actually be available at the
> time the completion function runs, causing a build failure.
>
> Similarly, packages providing loader libraries should append to
> PIXBUFCACHE_SYSROOT_DEPS with their runtime dependencies.
Is this related to
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10102
? Or are you seeing completely different errors?
> Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
> ---
> meta/classes/pixbufcache.bbclass | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
> index dbe11e1..3c1e398 100644
> --- a/meta/classes/pixbufcache.bbclass
> +++ b/meta/classes/pixbufcache.bbclass
> @@ -65,3 +65,17 @@ pixbufcache_sstate_postinst() {
> fi
> }
>
> +# Add all of the dependencies of gdk-pixbuf as dependencies of
> +# do_populate_sysroot_setscene so that pixbufcache_sstate_postinst can work
> +# (otherwise gdk-pixbuf-query-loaders may not exist or link). Only add
> +# gdk-pixbuf-native if we're not building gdk-pixbuf itself.
> +#
> +# Packages that use this class should extend this variable with their runtime
> +# dependencies.
> +PIXBUFCACHE_SYSROOT_DEPS = ""
> +PIXBUFCACHE_SYSROOT_DEPS_class-native = "\
> + ${@['gdk-pixbuf-native:do_populate_sysroot_setscene', '']['${BPN}' == 'gdk-pixbuf']} \
> +"
> +
> +do_populate_sysroot_setscene[depends] += "${PIXBUFCACHE_SYSROOT_DEPS}"
> +do_populate_sysroot[depends] += "${@d.getVar('PIXBUFCACHE_SYSROOT_DEPS', True).replace('_setscene','')}"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
next prev parent reply other threads:[~2016-10-11 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 14:17 [PATCH 1/2] pixbufcache: Ensure sysroot dependencies are satisfied Kyle Russell
2016-10-11 14:17 ` [PATCH 2/2] librsvg: Add missing pixbufcache dependencies Kyle Russell
2016-10-11 14:57 ` Burton, Ross
2016-10-11 16:44 ` Kyle Russell
2016-10-13 13:09 ` Burton, Ross
2016-10-14 9:55 ` Kyle Russell
2016-11-10 13:58 ` Kyle Russell
2016-10-11 18:29 ` Martin Jansa [this message]
2016-10-11 18:51 ` [PATCH 1/2] pixbufcache: Ensure sysroot dependencies are satisfied Kyle Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011182933.GB2917@jama \
--to=martin.jansa@gmail.com \
--cc=bkylerussell@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox