From: Denys Dmytriyenko <denis@denix.org>
To: Marek Vasut <marex@denx.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/5] u-boot: Drop PV altogether
Date: Wed, 19 Oct 2016 17:15:32 -0400 [thread overview]
Message-ID: <20161019211532.GV2494@denix.org> (raw)
In-Reply-To: <26a26c16-7eaf-70c3-698e-164bdba67d8b@denx.de>
On Wed, Oct 19, 2016 at 11:00:02PM +0200, Marek Vasut wrote:
> On 10/19/2016 10:10 PM, Denys Dmytriyenko wrote:
> > On Tue, Oct 18, 2016 at 11:55:12PM +0200, Marek Vasut wrote:
> >> Drop the explicit setting of PV altogether. This changes the U-Boot
> >> version string from "v20yy.mm" to "20yy.mm" , so layer setting the
> >> PREFERRED_VERSION_u-boot must be updated by removing the leading 'v'.
> >
> > Finally!
> > But do we need to bump PE to ensure upgrade path and proper sorting?
>
> I don't think so, since the whole U-Boot version got updated.
Still, vXXXX.YY will always sort higher than XXXX.YY no matter what digits
there are. That's what PE is for, to get the sorting working even when
versioning schema gets changed in major way like this one...
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> >> Cc: Denys Dmytriyenko <denis@denix.org>
> >
> > Acked-by: Denys Dmytriyenko <denis@denix.org>
>
> Thanks!
>
> btw. given the layout of the u-boot package after this, updating is a
> matter of mv+sed combo :)
>
> >> ---
> >> meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> >> index 0a90621..a535df1 100644
> >> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> >> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> >> @@ -9,8 +9,6 @@ LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
> >> # repo during parse
> >> SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
> >>
> >> -PV = "v2016.09.01"
> >> -
> >> SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
>
> And once 2016.11 is out, I believe I can even drop the ;branch= bit here.
>
> >> S = "${WORKDIR}/git"
> >> --
> >> 2.9.3
> >>
>
>
> --
> Best regards,
> Marek Vasut
>
next prev parent reply other threads:[~2016-10-19 21:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:55 [PATCH 1/5] u-boot: Factor out common bits Marek Vasut
2016-10-18 21:55 ` [PATCH 2/5] u-boot: Update to 2016.09.01 release Marek Vasut
2016-10-19 12:06 ` Alexander Kanavin
2016-10-19 20:10 ` Denys Dmytriyenko
2016-10-18 21:55 ` [PATCH 3/5] u-boot: Drop the +git part from PV Marek Vasut
2016-10-19 20:15 ` Denys Dmytriyenko
2016-10-18 21:55 ` [PATCH 4/5] u-boot: Drop PV altogether Marek Vasut
2016-10-19 12:09 ` Alexander Kanavin
2016-10-19 20:27 ` Denys Dmytriyenko
2016-10-19 20:10 ` Denys Dmytriyenko
2016-10-19 21:00 ` Marek Vasut
2016-10-19 21:15 ` Denys Dmytriyenko [this message]
2016-10-19 21:39 ` Burton, Ross
2016-10-19 22:53 ` Marek Vasut
2016-10-20 10:13 ` Burton, Ross
2016-10-20 13:36 ` Marek Vasut
2016-10-18 21:55 ` [PATCH 5/5] u-boot: Drop redundant comment Marek Vasut
2016-10-19 20:11 ` Denys Dmytriyenko
2016-10-19 20:13 ` [PATCH 1/5] u-boot: Factor out common bits Denys Dmytriyenko
2016-10-19 20:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019211532.GV2494@denix.org \
--to=denis@denix.org \
--cc=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox