Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Nathan Rossi <nathan@nathanrossi.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] kernel-fitimage.bbclass: Check value of UBOOT_SIGN_ENABLE
Date: Fri, 21 Oct 2016 22:07:26 +1000	[thread overview]
Message-ID: <20161021120728.22639-1-nathan@nathanrossi.com> (raw)

Check the value of UBOOT_SIGN_ENABLE, as it is defaulted to "0" which
for matches as True in python due to being a non-empty string.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
 meta/classes/kernel-fitimage.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 8580247f82..3bbf91f65a 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -26,7 +26,7 @@ python __anonymous () {
         # Verified boot will sign the fitImage and append the public key to
         # U-boot dtb. We ensure the U-Boot dtb is deployed before assembling
         # the fitImage:
-        if d.getVar('UBOOT_SIGN_ENABLE', True):
+        if d.getVar('UBOOT_SIGN_ENABLE', True) == "1":
             uboot_pn = d.getVar('PREFERRED_PROVIDER_u-boot', True) or 'u-boot'
             d.appendVarFlag('do_assemble_fitimage', 'depends', ' %s:do_deploy' % uboot_pn)
 }
-- 
2.9.3


             reply	other threads:[~2016-10-21 12:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 12:07 Nathan Rossi [this message]
2016-10-21 12:07 ` [PATCH] kernel-fitimage.bbclass: Allow unset load/entry addresses for ramdisks Nathan Rossi
2016-11-23  5:29   ` Nathan Rossi
2017-01-12  3:27     ` Nathan Rossi
2016-10-21 12:07 ` [PATCH] kernel-fitimage.bbclass: Don't assume KERNEL_IMAGETYPE == fitImage Nathan Rossi
2016-11-23  5:28   ` Nathan Rossi
2016-11-23  5:29 ` [PATCH] kernel-fitimage.bbclass: Check value of UBOOT_SIGN_ENABLE Nathan Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021120728.22639-1-nathan@nathanrossi.com \
    --to=nathan@nathanrossi.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox