public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Paul Barker <paul@paulbarker.me.uk>
To: OpenEmbedded Core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: Allow ${S} to be overridden
Date: Sat, 5 Nov 2016 10:14:38 +0000	[thread overview]
Message-ID: <20161105101438.1ef1f627@nuc.betafive.co.uk> (raw)
In-Reply-To: <1477161480-20271-1-git-send-email-paul@paulbarker.me.uk>

On Sat, 22 Oct 2016 19:38:00 +0100
Paul Barker <paul@paulbarker.me.uk> wrote:

> For kernel recipes which fetch sources from an archive instead of git, it's
> necessary to point ${S} at the extracted sources. In kernel.bbclass there is
> already logic in base_do_unpack_append() to link ${KERNEL_STAGING_DIR} to ${S}
> if these aren't the same, so we just need to be able to override ${S}.
> 
> Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 25a153c..a7d467b 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -3,7 +3,7 @@ inherit linux-kernel-base kernel-module-split
>  PROVIDES += "virtual/kernel"
>  DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross bc-native lzop-native"
>  
> -S = "${STAGING_KERNEL_DIR}"
> +S ?= "${STAGING_KERNEL_DIR}"
>  B = "${WORKDIR}/build"
>  KBUILD_OUTPUT = "${B}"
>  OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT"

Ping on this. Anyone had a chance to look at it?


  reply	other threads:[~2016-11-05 10:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-22 18:38 [PATCH] kernel.bbclass: Allow ${S} to be overridden Paul Barker
2016-11-05 10:14 ` Paul Barker [this message]
2016-11-09  1:04   ` Burton, Ross
2016-11-09  2:23     ` Bruce Ashfield
2016-11-09 10:04       ` Burton, Ross
2016-11-09 11:34         ` Burton, Ross
2016-11-09 13:09         ` Bruce Ashfield
2016-11-09 18:08           ` Paul Barker
2016-11-09 23:42             ` Andre McCurdy
2016-11-11 19:39               ` Paul Barker
2016-11-14  7:59                 ` Patrick Ohly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161105101438.1ef1f627@nuc.betafive.co.uk \
    --to=paul@paulbarker.me.uk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox