Re: [PATCH 0/5] wic: bugfixes & --fixed-size support

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Tue, Nov 08, 2016 at 04:56:06PM +0100, Maciej Borzecki wrote:
> The patch series is a follow-up after a previous attempt of adding
> --reserved-size option to wic[1].
> 
> The series introduces a number of fixes in patches 1 - 4.
> 
> The last patch in the series introduces --fixed-size option as discussed in [1].
> The patch also introduces minor refactoring to code responsible for computing
> partition size.
> 
> Aside from new option, another user-visible change is how the size rootfs
> partitions with vfat is calculated. In previous code, vfat rootfs partition size
> did not account for --extra-space nor --overhead-factor. Now, all rootfs
> partitions (except for squashfs) are subject to the same rules of partition
> sizing.
> 
Thank you for the patchset!

+1 (if my comments are taken into account)

It would be great if you add tests for this functionality to oe-selftest
wic suite.

> http://lists.openembedded.org/pipermail/openembedded-core/2016-October/127634.html
> 
> Maciej Borzecki (5):
>   wic: make sure that partition size is always an integer in internal
>     processing
>   wic: use partition size when creating empty partition files
>   wic: check that filesystem is specified for a rootfs partition
>   wic: fix function comment typos
>   wic: add --fixed-size wks option
> 
>  scripts/lib/wic/help.py                | 14 +++--
>  scripts/lib/wic/imager/direct.py       |  2 +-
>  scripts/lib/wic/ksparser.py            | 41 +++++++++++++--
>  scripts/lib/wic/partition.py           | 93 +++++++++++++++++++++-------------
>  scripts/lib/wic/utils/partitionedfs.py |  6 +--
>  5 files changed, 109 insertions(+), 47 deletions(-)
> 
> -- 
> 2.5.0
> 

-- 
--
Regards,
Ed