From: Tom Rini <trini@konsulko.com>
To: Nathan Lynch <nathan_lynch@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] busybox: enable fractional sleep arguments
Date: Fri, 18 Nov 2016 15:22:05 -0500 [thread overview]
Message-ID: <20161118202205.GP2546@bill-the-cat> (raw)
In-Reply-To: <1479415791-28938-1-git-send-email-nathan_lynch@mentor.com>
On Thu, Nov 17, 2016 at 02:49:51PM -0600, Nathan Lynch wrote:
> Fractional durations (e.g. 0.5s) for the sleep command are useful and
> not terribly uncommon in practice, especially in scripts associated
> with test cases (e.g. mdadm, lttng-tools). Enable FEATURE_FLOAT_SLEEP
> by default in order to avoid having to patch every instance of a
> script using a fractional sleep.
>
> The busybox binary gains a few hundred bytes in text (armv5e shown):
>
> $ size -x busybox.nosuid.{before,after}
> text data bss dec hex filename
> 0x89382 0x71d 0x2250 572655 8bcef busybox.nosuid.before
> 0x8954e 0x721 0x2250 573119 8bebf busybox.nosuid.after
>
> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
It's also something I've seen customer use as well in their scripts so
this would remove the need to add it to the local layer.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
prev parent reply other threads:[~2016-11-18 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 20:49 [PATCH] busybox: enable fractional sleep arguments Nathan Lynch
2016-11-18 20:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118202205.GP2546@bill-the-cat \
--to=trini@konsulko.com \
--cc=nathan_lynch@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox