From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f195.google.com (mail-wj0-f195.google.com [209.85.210.195]) by mail.openembedded.org (Postfix) with ESMTP id AFEF471B08 for ; Thu, 24 Nov 2016 09:27:49 +0000 (UTC) Received: by mail-wj0-f195.google.com with SMTP id kp2so2830394wjc.0 for ; Thu, 24 Nov 2016 01:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0hQNfwkr1oC5YonlGOCbWIGvpwZG+N1Kxofqy8o2jmw=; b=x8YChXvAV/4TgMlmwrCuS9YDHIMYePJg5O+3du4SGoUhr2od2hvXfF4GDyzOjfVbvt tGWLWuaQDxWJ6qgMROC4M5Yi8Pzjo+o+iXwz551ZN0dZpQIpQ/HgZKd9E7v6UBZIA599 4zfMLhGmxBjgzodCW8pUSEvBMsMQPXBeypGQ8KH1PvhCIRk9uL4BTYo7gnANMBE14PBq AQXW0lkxyn0IxellGRvBTwEhyH6z147dDCgL0gCFK9g1+uReHNTVix4XPE/ksLA9dPRO KxpnMNFxKK8pTbt+2fVuGfbTn7ZP6oT6j8bjNtkkGy8uiRQp4ms2Rydx8toBlncdgN/r xE0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0hQNfwkr1oC5YonlGOCbWIGvpwZG+N1Kxofqy8o2jmw=; b=SBs2WzTJcMqmqH1IEWA+KFmay4lJtT9g6OckRUMa/FHf+WGVgKcsXAuQGj7PMckK+q cF/cG8iG1irkI5bqa2sPjQPlf7lCK9d14D2qsY3ijvHr01BdaMQEWbUB1ZMuPafGm8d0 13SQfs4UD9V9SMPilfi8wiKuisFlN0mRWjNSKcuA1uA2xOjHLdV/QaTue88NLwG9nGOS AaiGOiF9yBu96au04yVXNSvYOmc04vNuJE1Gg9NZrpdeDZ0dS02XvHmdLr46N0cNZngk cfWPNJZplz4IhiC2D+StIloFq6yR+AVgxdOSZkAkf8SOFiiVlek9RwpKa29l26CZUD7T /juA== X-Gm-Message-State: AKaTC020gvSXUH0dXvCJnNbLMoMAVLPvQ3/i7Xt5uHgQ/B0dPhnhwW68wJwMbQOx8uf4sw== X-Received: by 10.194.95.35 with SMTP id dh3mr1424153wjb.141.1479979670745; Thu, 24 Nov 2016 01:27:50 -0800 (PST) Received: from localhost.localdomain ([185.47.80.46]) by smtp.gmail.com with ESMTPSA id ua15sm40809313wjb.1.2016.11.24.01.27.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Nov 2016 01:27:50 -0800 (PST) From: David Vincent To: openembedded-core@lists.openembedded.org, haris.okanovic@ni.com, markus.lehtonen@linux.intel.com Date: Thu, 24 Nov 2016 10:26:36 +0100 Message-Id: <20161124092636.9533-1-freesilicon@gmail.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: References: Subject: [PATCH v3] classes: Fix alternatives and rc.d ordering X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 09:27:51 -0000 When using an alternative as an initscript, the ordering between update-rc.d and update-alternatives tasks during prerm and postinst tasks must always be the following in order to work: * prerm: - stop daemon - remove alternative * postinst: - add alternative - start daemon This patchset adds comments to the scripts generated by both classes and organize the generated sections based on those comments. [YOCTO #10433] Signed-off-by: David Vincent --- meta/classes/update-alternatives.bbclass | 27 +++++++++++++++++++++------ meta/classes/update-rc.d.bbclass | 20 ++++++++++++++++++-- 2 files changed, 39 insertions(+), 8 deletions(-) diff --git a/meta/classes/update-alternatives.bbclass b/meta/classes/update-alternatives.bbclass index 1fdd681..bbd5a47 100644 --- a/meta/classes/update-alternatives.bbclass +++ b/meta/classes/update-alternatives.bbclass @@ -195,8 +195,8 @@ python populate_packages_updatealternatives () { pkgdest = d.getVar('PKGD', True) for pkg in (d.getVar('PACKAGES', True) or "").split(): # Create post install/removal scripts - alt_setup_links = "" - alt_remove_links = "" + alt_setup_links = "# Begin section update-alternatives\n" + alt_remove_links = "# Begin section update-alternatives\n" for alt_name in (d.getVar('ALTERNATIVE_%s' % pkg, True) or "").split(): alt_link = d.getVarFlag('ALTERNATIVE_LINK_NAME', alt_name, True) alt_target = d.getVarFlag('ALTERNATIVE_TARGET_%s' % pkg, alt_name, True) or d.getVarFlag('ALTERNATIVE_TARGET', alt_name, True) @@ -219,8 +219,11 @@ python populate_packages_updatealternatives () { # Default to generate shell script.. eventually we may want to change this... alt_target = os.path.normpath(alt_target) - alt_setup_links += '\tupdate-alternatives --install %s %s %s %s\n' % (alt_link, alt_name, alt_target, alt_priority) - alt_remove_links += '\tupdate-alternatives --remove %s %s\n' % (alt_name, alt_target) + alt_setup_links += 'update-alternatives --install %s %s %s %s\n' % (alt_link, alt_name, alt_target, alt_priority) + alt_remove_links += 'update-alternatives --remove %s %s\n' % (alt_name, alt_target) + + alt_setup_links += "# End section update-alternatives\n" + alt_remove_links += "# End section update-alternatives\n" if alt_setup_links: # RDEPENDS setup @@ -232,12 +235,24 @@ python populate_packages_updatealternatives () { bb.note('adding update-alternatives calls to postinst/prerm for %s' % pkg) bb.note('%s' % alt_setup_links) postinst = d.getVar('pkg_postinst_%s' % pkg, True) or '#!/bin/sh\n' - postinst += alt_setup_links + postinst = postinst.splitlines(True) + try: + index = postinst.index('# Begin section update-rc.d\n') + postinst.insert(index, alt_setup_links) + except ValueError: + postinst.append(alt_setup_links) + postinst = ''.join(postinst) d.setVar('pkg_postinst_%s' % pkg, postinst) bb.note('%s' % alt_remove_links) prerm = d.getVar('pkg_prerm_%s' % pkg, True) or '#!/bin/sh\n' - prerm += alt_remove_links + prerm = prerm.splitlines(True) + try: + index = prerm.index('# End section update-rc.d\n') + prerm.insert(index + 1, alt_remove_links) + except ValueError: + prerm.append(alt_remove_links) + prerm = ''.join(prerm) d.setVar('pkg_prerm_%s' % pkg, prerm) } diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass index 321924b..18df2dc 100644 --- a/meta/classes/update-rc.d.bbclass +++ b/meta/classes/update-rc.d.bbclass @@ -26,6 +26,7 @@ fi } updatercd_postinst() { +# Begin section update-rc.d if type update-rc.d >/dev/null 2>/dev/null; then if [ -n "$D" ]; then OPT="-r $D" @@ -34,12 +35,15 @@ if type update-rc.d >/dev/null 2>/dev/null; then fi update-rc.d $OPT ${INITSCRIPT_NAME} ${INITSCRIPT_PARAMS} fi +# End section update-rc.d } updatercd_prerm() { +# Begin section update-rc.d if [ -z "$D" -a -x "${INIT_D_DIR}/${INITSCRIPT_NAME}" ]; then ${INIT_D_DIR}/${INITSCRIPT_NAME} stop || : fi +# End section update-rc.d } updatercd_postrm() { @@ -102,13 +106,25 @@ python populate_packages_updatercd () { postinst = d.getVar('pkg_postinst_%s' % pkg, True) if not postinst: postinst = '#!/bin/sh\n' - postinst += localdata.getVar('updatercd_postinst', True) + postinst = postinst.splitlines(True) + try: + index = postinst.index('# End section update-alternatives\n') + postinst.insert(index + 1, localdata.getVar('updatercd_postinst', True)) + except ValueError: + postinst.append(localdata.getVar('updatercd_postinst', True)) + postinst = ''.join(postinst) d.setVar('pkg_postinst_%s' % pkg, postinst) prerm = d.getVar('pkg_prerm_%s' % pkg, True) if not prerm: prerm = '#!/bin/sh\n' - prerm += localdata.getVar('updatercd_prerm', True) + prerm = prerm.splitlines(True) + try: + index = prerm.index('# Begin section update-alternatives\n') + prerm.insert(index, localdata.getVar('updatercd_prerm', True)) + except ValueError: + prerm.append(localdata.getVar('updatercd_prerm', True)) + prerm = ''.join(prerm) d.setVar('pkg_prerm_%s' % pkg, prerm) postrm = d.getVar('pkg_postrm_%s' % pkg, True) -- 2.10.2