Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Rick Altherr <raltherr@google.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
Date: Thu, 19 Jan 2017 12:37:00 -0500	[thread overview]
Message-ID: <20170119173700.GX15833@denix.org> (raw)
In-Reply-To: <20170119165803.22583-1-raltherr@google.com>

On Thu, Jan 19, 2017 at 08:58:03AM -0800, Rick Altherr wrote:
> If the ramdisk load and entry parameters are omitted in the FIT image
> specification, U-Boot will determine if the ramdisk needs to be
> relocated and will automatically allocate a location in RAM if so.

Sometimes it's useful to load ramdisk in a specific location. Your patch 
unconditionally removes this support, which is not a desired change. I have 
a patch queued up to do it conditionally, which I'll try to submit shortly.

-- 
Denys


> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>  meta/classes/kernel-fitimage.bbclass | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 2934b3a31a..ee721d1fff 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -187,8 +187,6 @@ fitimage_emit_section_ramdisk() {
>                          arch = "${UBOOT_ARCH}";
>                          os = "linux";
>                          compression = "none";
> -                        load = <${UBOOT_RD_LOADADDRESS}>;
> -                        entry = <${UBOOT_RD_ENTRYPOINT}>;
>                          hash@1 {
>                                  algo = "${ramdisk_csum}";
>                          };
> -- 
> 2.11.0.483.g087da7b7c-goog
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


  reply	other threads:[~2017-01-19 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 16:58 [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address Rick Altherr
2017-01-19 17:37 ` Denys Dmytriyenko [this message]
2017-01-19 17:40   ` Burton, Ross
2017-01-19 17:41     ` Rick Altherr
2017-01-19 17:45     ` Denys Dmytriyenko
2017-01-19 18:16       ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119173700.GX15833@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raltherr@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox