From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mail.openembedded.org (Postfix) with ESMTP id ECC09730A4 for ; Mon, 6 Mar 2017 18:04:00 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2017 10:03:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,254,1484035200"; d="scan'208";a="1119129469" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 06 Mar 2017 10:03:49 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id A29586A4080; Mon, 6 Mar 2017 10:03:45 -0800 (PST) Date: Mon, 6 Mar 2017 19:50:10 +0200 From: Ed Bartosh To: "Burton, Ross" Message-ID: <20170306175010.GA18369@linux.intel.com> Reply-To: ed.bartosh@linux.intel.com References: <1488814260-8668-1-git-send-email-ed.bartosh@linux.intel.com> MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: OE-core Subject: Re: [PATCH v2] sstate.bbclass: update .siginfo atime X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 18:04:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 06, 2017 at 04:49:25PM +0000, Burton, Ross wrote: > On 6 March 2017 at 15:31, Ed Bartosh wrote: > > > + [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo > > > > $ ( [ -h / ] && echo something ); echo $? > 1 > > If the -h fails then this is still going to cause sstate_unpack_package to > trap. I don't think it will as '&&' and '||' lists are among other special cases where shell doesn't exits on error. Here is a proof: $ cat test.sh set -e trap 'ouch!' ERR foo() { [ -h /etc/fstab ] && echo 'fstab is a symlink' echo 'end of foo' } foo echo $? $ $ sh -e test.sh end of foo 0 -- Regards, Ed