From: Mike Crowe <mac@mcrowe.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] ccache: Disable CCACHE_HASHDIR by default
Date: Wed, 15 Mar 2017 11:54:19 +0000 [thread overview]
Message-ID: <20170315115419.GA17975@mcrowe.com> (raw)
In-Reply-To: <20170313135146.GA4512@mcrowe.com>
On Monday 13 March 2017 at 13:51:46 +0000, Mike Crowe wrote:
> On Monday 13 March 2017 at 13:33:27 +0000, Burton, Ross wrote:
> > On 11 March 2017 at 16:54, Mike Crowe <mac@mcrowe.com> wrote:
> >
> > > ccache apparently does this so that paths in the debug information will
> > > always be correct. In an OE world these paths may already be missing or
> > > incorrect due to rm_work or the use of a shared sstate cache, so it doesn't
> > > seem as if we're losing much by disabling this feature.
> > >
> >
> > In an OE world we tell GCC to rewrite them to be target paths anyway, so
> > this isn't a problem. Maybe worth rewriting the commit message?
> >
> > (see bitbake.conf, -fdebug-prefix-map)
>
> I wasn't aware of that.
>
> ccache does have some technology to detect this situation:
>
> Exception: The CWD will not be included in the hash if *base_dir* is set
> (and matches the CWD) and the compiler option *-fdebug-prefix-map* is
> used.
>
> I think this means that if CCACHE_BASEDIR is set appropriately then it
> wouldn't be necessary to set CCACHE_NOHASHDIR. (Looking at the ccache code,
> I think that "matches the CWD" means "CWD is under *base_dir*" rather than
> the two needing to be identical.)
>
> I shall investigate why things weren't working correctly for us. In the
> meantime I don't think my patch is yet proven to be doing the right thing.
Unfortunately ccache only supports this special behaviour for the last
-fdebug-prefix-map argument. All the arguments make it through to the
compiler, but the last one isn't enough to stop the current directory being
hashed by default.
I've raised this as https://github.com/ccache/ccache/issues/163 .
It seems that for the time being setting CCACHE_NOHASHDIR is required to
make ccache effective for us. I'll reword the commit message based on
Ross's input and this information.
Thanks.
Mike.
next prev parent reply other threads:[~2017-03-15 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 16:54 [PATCH] ccache: Disable CCACHE_HASHDIR by default Mike Crowe
2017-03-13 13:33 ` Burton, Ross
2017-03-13 13:51 ` Mike Crowe
2017-03-15 11:54 ` Mike Crowe [this message]
2017-06-13 9:41 ` Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315115419.GA17975@mcrowe.com \
--to=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox