Re: [PATCH v4 0/5] wic: selftest: enhancements for non-x86 MACHINE support & fixed-size tests

[Ed Bartosh <ed.bartosh@linux.intel.com>]

Hi Maciej,

The patchset looks great! Thank you!


On Tue, Mar 21, 2017 at 12:35:00PM +0100, Maciej Borzecki wrote:
> v4 of a series with enhancements and new test cases for wic selftest.
> The enhancements allow for running wic selftest for non-x86 MACHINE,
> such as qemuarm (the whole series was verified on qemux86-64 and
> qemuarm).
> 
> The first patch adds a machine independent kickstart file - wictestdisk.
> Most of test cases build a disk image using one of the kickstart files
> shipped in Poky (mostly directdisk. These are usually x86 oriented due
> to use of syslinux and cannot be used when running with non-x86
> compatible MACHINE. On the other hand, the image built during tests does
> not need to be bootable (with exception of TCs that verify if the image
> is indeed bootable).
> 
> Patch 2 introduces wictestdisk in test cases where its use is possible.
> 
> Patch 3 adds only_for_arch() convenience decorator and applies it to test
> cases where x86 specific image must be used. In the end, only 13 TCs are
> skipped on qemuarm.
> 
> Changes from previous version:
> - renamed onlyForArch() to only_for_arch(), changed input arguments to
>   take image name and list of compatible architectures
> - pylint fixes
> 
> Patch 4 removes some assumptions about kernel image type.
> 
> Patch 5 adds tests for --fixed-size partition flags.
> 
> Changes from previous version:
> - pylint fixes
> 
> Maciej Borzecki (5):
>   selftest: wictestdisk: machine agnostic WKS for use with selftest
>   selftest: wic: replace directdisk with wictestdisk where possible
>   wic: selftest: avoid COMPATIBLE_HOST issues
>   wic: selftest: do not assume bzImage kernel image
>   wic: selftest: add tests for --fixed-size partition flags
> 
>  meta-selftest/wic/wictestdisk.wks |   7 ++
>  meta/lib/oeqa/selftest/wic.py     | 171 ++++++++++++++++++++++++++++++--------
>  2 files changed, 144 insertions(+), 34 deletions(-)
>  create mode 100644 meta-selftest/wic/wictestdisk.wks
> 
> -- 
> 2.9.3
> 

-- 
--
Regards,
Ed