From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 004F171DC9 for ; Mon, 15 May 2017 17:33:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id E026120B7A; Mon, 15 May 2017 17:33:51 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kqbm6wrz61vy; Mon, 15 May 2017 17:33:51 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 7124820756; Mon, 15 May 2017 17:33:49 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id EDDAC1624C3; Mon, 15 May 2017 13:33:48 -0400 (EDT) Date: Mon, 15 May 2017 13:33:48 -0400 From: Denys Dmytriyenko To: "C.R. Guo" Message-ID: <20170515173348.GK28053@denix.org> References: <1494406033-28833-1-git-send-email-B40290@freescale.com> <1494406033-28833-3-git-send-email-B40290@freescale.com> <20170512151226.GF28053@denix.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "openembedded-core@lists.openembedded.org" Subject: Re: [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 May 2017 17:33:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 15, 2017 at 03:09:32AM +0000, C.R. Guo wrote: > Hello Denys , > > > for example: > KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb" ^^^^^^^^^^^^^^^^^^^^ > ${DTB}= "freescale/fsl-ls1046a-rdb.dtb" ^^^^^^^^^^^^^^^^^^^^ > DTB=`basename ${DTB}` > > ${DTB}= "fsl-ls1046a-rdb.dtb" > > if use DTB_PATH="arch/${ARCH}/boot/dts/${DTB}" > > > DTB_PATH = ="arch/${ARCH}/boot/dts/fsl-ls1046a-rdb.dtb" > > but dtb files real path is arch/${ARCH}/boot/dts/freescale/fsl-ls1046a-rdb.dtb" The original DTB and KERNEL_DEVICETREE above still have the correct path, don't they? -- Denys > -----Original Message----- > From: Denys Dmytriyenko [mailto:denis@denix.org] > Sent: Friday, May 12, 2017 11:12 PM > To: Chunrong Guo > Cc: openembedded-core@lists.openembedded.org; C.R. Guo > Subject: Re: [OE-core] [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue > > On Wed, May 10, 2017 at 04:47:13PM +0800, Chunrong Guo wrote: > > From: Chunrong Guo > > > > * For example: > > KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb" > > > > ${DTB}= "freescale/fsl-ls1046a-rdb.dtb" > > > > but only fsl-ls1046a-rdb.dtb should be used in fit-image.its > > > > Signed-off-by: Chunrong Guo > > --- > > meta/classes/kernel-fitimage.bbclass | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes/kernel-fitimage.bbclass > > b/meta/classes/kernel-fitimage.bbclass > > index 9fa836f..3171d10 100644 > > --- a/meta/classes/kernel-fitimage.bbclass > > +++ b/meta/classes/kernel-fitimage.bbclass > > @@ -346,7 +346,10 @@ fitimage_assemble() { > > bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used." > > DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'` > > fi > > - DTB_PATH="arch/${ARCH}/boot/dts/${DTB}" > > + > > + DTB=`basename ${DTB}` > > + DTB_PATH=`find arch/${ARCH}/boot -name > > +"${DTB}"` > > Any way to not use "find" here? Shouldn't KERNEL_DEVICETREE and DTB_PATH already give you the full path? > > > > + > > if [ ! -e "${DTB_PATH}" ]; then > > DTB_PATH="arch/${ARCH}/boot/${DTB}" > > fi > > -- > > 1.8.3.2 > > > > -- > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core >