Re: [PATCH] libgcrypt: Revert to inheriting from binconfig

[Mike Crowe <mac@mcrowe.com>]

On Wednesday 24 May 2017 at 23:44:49 +0100, Richard Purdie wrote:
> On Wed, 2017-05-24 at 17:25 +0100, Burton, Ross wrote:
> > 
> > On 24 May 2017 at 14:52, Mike Crowe <mac@mcrowe.com> wrote:
> > > Oh, I thought that binconfig.bbclass swung through hoops in order
> > > to make
> > > the scripts work well enough. Is that not true?
> > > 
> > > Many other recipes are still inheriting binconfig rather than
> > > binconfig-disabled: apr, curl, gnutls, libtasn1.
> > > 
> > binconfig goes through hoops that are just not required with
> > pkgconfig, and the hoops are hacks which may not be reliable.  I
> > can't remember the details but I do remember that libgcrypt/gnupg was
> > a worst offender here.
> > 
> > CCing Richard to see if he can remember why.
> > 
> > In the glorious future removing all binconfig scripts would be the
> > ideal, in my opinion.  Alternatively replacing them with glorified
> > pkgconfig wrappers.
> 
> We made a choice back then to go ahead and migrate these pieces to pkg-
> config regardless of upstream's views since its so much cleaner and
> less error prone than -config shell scripts which need hacking. We do
> also patch the autoconf macros those pieces of software ship so that
> pkg-config is used by the standard macros which covers most users
> (since we reautoconf software).

[snip]

> I appreciate that does cause some pain as we're doing something
> differently but I also believe it is justified. I would suggest
> reminding these upstreams who won't at least allow pkg-config in
> parallel that this does cause pain in the hope that if multiple people
> report it, they may rethink things.

I was unaware that oe-core's libgcrypt recipe provides a modified
libgcrypt.m4 in share/aclocal/ that uses pkg-config.

Inspired by the oe-core gnupg recipe, I deleted m4/libgcrypt.m4 from the
libmicrohttpd source directory in a do_configure_prepend and everything now
seems happy.

Thanks, and sorry for the unnecessary diversion.

Mike.