Re: [PATCH] connman: fix nftables dependency

[Andreas Oberritter <obi@opendreambox.org>]

Hi André,

On Mon, 19 Jun 2017 11:32:38 +0100
André Draszik <git@andred.net> wrote:

> From: André Draszik <adraszik@tycoint.com>
> 
> When building with nftables support, connman doesn't ever
> depend on the nftables command line tool.
> 
> connman will depend on libmnl and libnftnl at build and
> run time. In addition, the nftables rules it creates
> depend on various kernel modules being present.
> 
> Update the PACKAGECONFIG to reflect this.
> 

packageconfig creates runtime dependencies for the modules you added. This
will cause problems if the modules are built into the kernel binary. You
should add runtime recommendations instead.

Regards,
Andreas

> Signed-off-by: André Draszik <adraszik@tycoint.com>
> Acked-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index ab18f2fe01..132a58ff40 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -51,7 +51,7 @@ PACKAGECONFIG[l2tp] = "--enable-l2tp --with-l2tp=${sbindir}/xl2tpd,--disable-l2t
>  PACKAGECONFIG[pptp] = "--enable-pptp --with-pptp=${sbindir}/pptp,--disable-pptp,,pptp-linux"
>  # WISPr support for logging into hotspots, requires TLS
>  PACKAGECONFIG[wispr] = "--enable-wispr,--disable-wispr,gnutls,"
> -PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,nftables,nftables"
> +PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,libmnl libnftnl,kernel-module-nf-tables-ipv4 kernel-module-nft-chain-nat-ipv4 kernel-module-nft-chain-route-ipv4 kernel-module-nft-meta kernel-module-nft-masq-ipv4 kernel-module-nft-nat"
>  PACKAGECONFIG[iptables] = "--with-firewall=iptables ,,iptables,iptables"
>  
>  INITSCRIPT_NAME = "connman"