From: Denys Dmytriyenko <denis@denix.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: marex@denx.de, trini@konsulko.com, brad.mouring@ni.com,
OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] u-boot-fw-utils: Allow replacement of fw_env.config
Date: Tue, 20 Jun 2017 19:55:44 -0400 [thread overview]
Message-ID: <20170620235544.GO28053@denix.org> (raw)
In-Reply-To: <20170620221512.21860-1-otavio@ossystems.com.br>
On Tue, Jun 20, 2017 at 07:15:12PM -0300, Otavio Salvador wrote:
> If a fw_env.config file is found in workdir, this is preferred over
> the U-Boot example.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.05.bb | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.05.bb b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.05.bb
> index c2e8f0fb84..0682f9274b 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.05.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2017.05.bb
> @@ -19,7 +19,14 @@ do_install () {
> install -d ${D}${sysconfdir}
> install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_printenv
> install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_setenv
> - install -m 0644 ${S}/tools/env/fw_env.config ${D}${sysconfdir}/fw_env.config
> +
> + # If a specific file is added in a .bbappend, this is used instead
> + # of the generic one
> + if [ -e ${WORKDIR}/fw_env.config ]; then
> + install -m 0644 ${WORKDIR}/fw_env.config ${D}${sysconfdir}/fw_env.config
I don't get it - if it's expected that a .bbappend will be adding a more
specific version of fw_env.config, why that .bbappend can't simply install
it with do_install_append()?
> + else
> + install -m 0644 ${S}/tools/env/fw_env.config ${D}${sysconfdir}/fw_env.config.example
> + fi
> }
>
> do_install_class-cross () {
> --
> 2.13.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2017-06-20 23:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 22:15 [PATCH] u-boot-fw-utils: Allow replacement of fw_env.config Otavio Salvador
2017-06-20 23:55 ` Denys Dmytriyenko [this message]
2017-06-21 12:03 ` Tom Rini
2017-06-21 15:50 ` Denys Dmytriyenko
2017-06-21 16:52 ` Tom Rini
2017-06-21 18:01 ` Otavio Salvador
2017-06-21 18:17 ` Tom Rini
2017-06-21 15:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620235544.GO28053@denix.org \
--to=denis@denix.org \
--cc=brad.mouring@ni.com \
--cc=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox