Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 3/3] copyleft_filter.bbclass: restore possiblity to filter on type
Date: Mon, 26 Jun 2017 09:18:34 +0100	[thread overview]
Message-ID: <20170626081834.23832-3-git@andred.net> (raw)
In-Reply-To: <20170626081834.23832-1-git@andred.net>

From: André Draszik <adraszik@tycoint.com>

Since the changes introduced in ae9102bda398
("copyleft_filter.bbclass: Allow to filter on name"), it is
impossible to filter on the recipe type, all recipes are
treated as though they should be included if the license
matches, irrespective of the COPYLEFT_RECIPE_TYPES
variable.

Fix this.

Signed-off-by: André Draszik <adraszik@tycoint.com>
---
 meta/classes/copyleft_filter.bbclass | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/meta/classes/copyleft_filter.bbclass b/meta/classes/copyleft_filter.bbclass
index 5867bb9f7e..c36bce431a 100644
--- a/meta/classes/copyleft_filter.bbclass
+++ b/meta/classes/copyleft_filter.bbclass
@@ -47,27 +47,27 @@ def copyleft_should_include(d):
     import oe.license
     from fnmatch import fnmatchcase as fnmatch
 
-    included, motive = False, 'recipe did not match anything'
-
     recipe_type = d.getVar('COPYLEFT_RECIPE_TYPE')
     if recipe_type not in oe.data.typed_value('COPYLEFT_RECIPE_TYPES', d):
-        include, motive = False, 'recipe type "%s" is excluded' % recipe_type
+        included, motive = False, 'recipe type "%s" is excluded' % recipe_type
+    else:
+        included, motive = False, 'recipe did not match anything'
 
-    include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
-    exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
+        include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
+        exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
 
-    try:
-        is_included, reason = oe.license.is_included(d.getVar('LICENSE'), include, exclude)
-    except oe.license.LicenseError as exc:
-        bb.fatal('%s: %s' % (d.getVar('PF'), exc))
-    else:
-        if is_included:
-            if reason:
-                included, motive = True, 'recipe has included licenses: %s' % ', '.join(reason)
-            else:
-                included, motive = False, 'recipe does not include a copyleft license'
+        try:
+            is_included, reason = oe.license.is_included(d.getVar('LICENSE'), include, exclude)
+        except oe.license.LicenseError as exc:
+            bb.fatal('%s: %s' % (d.getVar('PF'), exc))
         else:
-            included, motive = False, 'recipe has excluded licenses: %s' % ', '.join(reason)
+            if is_included:
+                if reason:
+                    included, motive = True, 'recipe has included licenses: %s' % ', '.join(reason)
+                else:
+                    included, motive = False, 'recipe does not include a copyleft license'
+            else:
+                included, motive = False, 'recipe has excluded licenses: %s' % ', '.join(reason)
 
     if any(fnmatch(d.getVar('PN'), name) \
             for name in oe.data.typed_value('COPYLEFT_PN_INCLUDE', d)):
-- 
2.11.0



  parent reply	other threads:[~2017-06-26  8:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 14:59 [PATCH 1/3] selftest/archiver: add tests for recipe type filtering André Draszik
2017-06-23 14:59 ` [PATCH 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-23 14:59 ` [PATCH 3/3] copyleft_filter.bbclass: restore possiblity to filter on type André Draszik
2017-06-23 15:15 ` [PATCH 1/3] selftest/archiver: add tests for recipe type filtering Leonardo Sandoval
2017-06-23 15:07   ` André Draszik
2017-06-23 15:43     ` Leonardo Sandoval
2017-06-26  8:18 ` [PATCH v2 " André Draszik
2017-06-26  8:18   ` [PATCH v2 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-26  8:18   ` André Draszik [this message]
2017-06-26  8:31 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev3) Patchwork
2017-06-26  8:31 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev4) Patchwork
2017-06-26  8:36 ` [PATCH v3 1/3] selftest/archiver: add tests for recipe type filtering André Draszik
2017-06-26  8:36   ` [PATCH v3 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-26  8:36   ` [PATCH v3 3/3] copyleft_filter.bbclass: restore possiblity to filter on type André Draszik
2017-06-26  9:01 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev6) Patchwork
2017-06-26  9:01 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev7) Patchwork
2017-06-26 10:32   ` André Draszik
2017-06-26 14:10     ` Leonardo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626081834.23832-3-git@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox