From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: liu.ming50@gmail.com
Cc: Ming Liu <peter.x.liu@external.atlascopco.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] qemux86.conf: drop do_image_wic task dependencies
Date: Wed, 2 Aug 2017 11:35:31 +0300 [thread overview]
Message-ID: <20170802083531.GB2944@linux.intel.com> (raw)
In-Reply-To: <1501607630-30241-4-git-send-email-liu.ming50@gmail.com>
On Tue, Aug 01, 2017 at 07:13:49PM +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> They are being controlled by WKS_FILE_DEPENDS_DEFAULT, the code here
> is redundant and incomplete as well.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
> meta/conf/machine/qemux86.conf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
> index c26dda2..f0bebbf 100644
> --- a/meta/conf/machine/qemux86.conf
> +++ b/meta/conf/machine/qemux86.conf
> @@ -29,4 +29,3 @@ MACHINE_FEATURES += "x86"
> MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
>
> WKS_FILE ?= "directdisk.wks"
> -do_image_wic[depends] += "syslinux:do_populate_sysroot syslinux-native:do_populate_sysroot mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
-1
WKS_FILE_DEPENDS_DEFAULT is a termporary setting aimed to easy
transition from using wic-tools to using WKS_FILE_DEPENDS. It contains
the whole set of packages that is not usually needed.
Please, consider setting WKS_FILE_DEPENDS with the minimum set of packages
required by directdisk.wks. This will faster the build as unneeded
packages will not be built.
You may want to look at "image_types_wic: set default WKS_FILE_DEPENDS"
commit for further details.
--
Regards,
Ed
next prev parent reply other threads:[~2017-08-02 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 17:13 [PATCH 0/4] Clean up some do_image_wic redundant code liu.ming50
2017-08-01 17:13 ` [PATCH 1/4] wic-image-minimal: drop WKS_FILE_DEPENDS definition liu.ming50
2017-08-02 8:38 ` Ed Bartosh
2017-08-01 17:13 ` [PATCH 2/4] image_types_wic.bbclass: deal with dependencies only with WKS_FILE_DEPENDS_DEFAULT liu.ming50
2017-08-02 8:26 ` Ed Bartosh
2017-08-02 8:56 ` Ming Liu
2017-08-01 17:13 ` [PATCH 3/4] qemux86.conf: drop do_image_wic task dependencies liu.ming50
2017-08-02 8:35 ` Ed Bartosh [this message]
2017-08-02 9:36 ` Ming Liu
2017-08-01 17:13 ` [PATCH 4/4] qemux86-64.conf: " liu.ming50
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802083531.GB2944@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=liu.ming50@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.x.liu@external.atlascopco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox