Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v8 3/3] kernel-devicetree.bbclass: Add support to generate append to kernel
Date: Tue, 12 Sep 2017 16:45:31 +0200	[thread overview]
Message-ID: <20170912164531.34d2af4f@t460p> (raw)
In-Reply-To: <20170912134551.12678-3-otavio@ossystems.com.br>

Hi Otavio,

On Tue, 12 Sep 2017 10:45:51 -0300
Otavio Salvador <otavio@ossystems.com.br> wrote:

> +do_configure_devicetree() {
> +	if [ "${KERNEL_DEVICETREE_BUNDLE}" = "1" ]; then
> +		if echo ${KERNEL_IMAGETYPE_FOR_MAKE} | grep -q 'zImage'; then
> +			config="${B}/.config"
> +			if ! grep -q 'CONFIG_ARM_APPENDED_DTB=y' $config; then
> +				bbwarn 'CONFIG_ARM_APPENDED_DTB is NOT enabled in the kernel. Enabling it to allow the kernel to boot with the Device Tree appended!'
> +				sed -i "/CONFIG_ARM_APPENDED_DTB[ =]/d" $config
> +				echo "CONFIG_ARM_APPENDED_DTB=y" >> $config
> +				echo "# CONFIG_ARM_ATAG_DTB_COMPAT is not set" >> $config

what about CONFIG_MIPS_APPENDED_DTB?

Can we ever make sure to cover all relevant architectures?

Regards,
Andreas

> +			fi
> +		else
> +			bberror 'The KERNEL_DEVICETREE_BUNDLE requires the KERNEL_IMAGETYPE to contain zImage.'
> +		fi
> +	fi
> +}



  reply	other threads:[~2017-09-12 14:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 13:45 [PATCH v8 1/3] kernel: Move Device Tree support to kernel.bbclass Otavio Salvador
2017-09-12 13:45 ` [PATCH v8 2/3] kernel-devicetree.bbclass: Rework to use tasks Otavio Salvador
2017-09-12 13:45 ` [PATCH v8 3/3] kernel-devicetree.bbclass: Add support to generate append to kernel Otavio Salvador
2017-09-12 14:45   ` Andreas Oberritter [this message]
2017-09-12 17:00     ` Otavio Salvador
2017-09-12 19:10       ` Andreas Oberritter
2017-09-12 20:26         ` Otavio Salvador
  -- strict thread matches above, loose matches on Subject: below --
2017-09-12 20:36 [PATCH v8 1/3] kernel: Move Device Tree support to kernel.bbclass Otavio Salvador
2017-09-12 20:36 ` [PATCH v8 3/3] kernel-devicetree.bbclass: Add support to generate append to kernel Otavio Salvador
2017-09-13  8:15   ` André Draszik
2017-09-13 12:30     ` Otavio Salvador
2017-09-14 10:26       ` André Draszik
2017-09-14 12:13         ` Otavio Salvador
2017-09-15  7:55           ` André Draszik
2017-09-14 10:19   ` André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170912164531.34d2af4f@t460p \
    --to=obi@opendreambox.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox