Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/5] kernel-fitimage: sanitize dtb section name (unbreak MIPS)
@ 2017-09-20  9:41 André Draszik
  2017-09-20  9:41 ` [PATCH 2/5] kernel-fitimage: unbreak UBOOT_ENTRYSYMBOL support André Draszik
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: André Draszik @ 2017-09-20  9:41 UTC (permalink / raw)
  To: openembedded-core

From: André Draszik <adraszik@tycoint.com>

We can't build fitImages for MIPS any more:
| Error: fit-image.its:21.27-28 syntax error
| FATAL ERROR: Unable to parse input tree
| uboot-mkimage: Can't read arch/mips/boot/fitImage.tmp: Invalid argument

Since commit cd2ed7f80b555add07795cc0cbaee866e6c193a3
("kernel-fitimage: dtb sections named by their filenames
and one config section for each dtb"), commit
1ec405ef5df82884c8997878bbe6c66d924b5127 in yocto, dtb
sections are named by the DTB filename, but the filename
can legally be in a subdirectory below
arch/$arch/boot/dts/, and on MIPS all DTBs are actually
in a subdirectory.

If so, mkimage fails with the above error message.

Unbreak this by replacing the offending character
(directory separator /)

Signed-off-by: André Draszik <adraszik@tycoint.com>
---
 meta/classes/kernel-fitimage.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 2630b47316..6f1b7667bc 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -351,6 +351,7 @@ fitimage_assemble() {
 				DTB_PATH="arch/${ARCH}/boot/${DTB}"
 			fi
 
+			DTB=$(echo "${DTB}" | tr '/' '_')
 			DTBS="${DTBS} ${DTB}"
 			fitimage_emit_section_dtb ${1} ${DTB} ${DTB_PATH}
 		done
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-09-20  9:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20  9:41 [PATCH 1/5] kernel-fitimage: sanitize dtb section name (unbreak MIPS) André Draszik
2017-09-20  9:41 ` [PATCH 2/5] kernel-fitimage: unbreak UBOOT_ENTRYSYMBOL support André Draszik
2017-09-20  9:41 ` [PATCH 3/5] kernel-uimage: optimise " André Draszik
2017-09-20  9:41 ` [PATCH 4/5] kernel-uboot: support compressed kernel on MIPS André Draszik
2017-09-20  9:41 ` [PATCH 5/5] kernel-fitimage: support MIPS (compressed) André Draszik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox