From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.seebs.net (mail.seebs.net [162.221.74.143]) by mail.openembedded.org (Postfix) with ESMTP id 9EB42783BA for ; Fri, 22 Sep 2017 16:52:04 +0000 (UTC) Received: from seebsdell (unknown [24.196.59.174]) by mail.seebs.net (Postfix) with ESMTPSA id F19582ADD07; Fri, 22 Sep 2017 11:52:05 -0500 (CDT) Date: Fri, 22 Sep 2017 11:52:04 -0500 From: Seebs To: Richard Purdie Message-ID: <20170922115204.37ef6f2c@seebsdell> In-Reply-To: <1506098477-5444-2-git-send-email-richard.purdie@linuxfoundation.org> References: <1506098477-5444-1-git-send-email-richard.purdie@linuxfoundation.org> <1506098477-5444-2-git-send-email-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/2] pseudo: Add fastop reply fix X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 16:52:05 -0000 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 Sep 2017 17:41:17 +0100 Richard Purdie wrote: > This changes the pseudo FASTOP functionality so that a reply to the > operation is required. This means we then cannot lose data if a > connection is closed. This in turn stops corruption if we run out of > file handles and have to close connections. > > This tweaks the connection closure patch to update the comment there > which is now outdated. > > Signed-off-by: Richard Purdie This looks reasonable to me. I did some testing with a very similar patch and concluded that, while it slowed performance slightly, it didn't slow it nearly as much as the pre-fastop behavior did. -s