Re: [PATCH 1/2] wic: When using --use-uuid make sure that we update the fstab with PARTUUID

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Thu, Sep 21, 2017 at 05:21:44PM -0400, Tom Rini wrote:
> On Thu, Sep 21, 2017 at 04:20:30PM -0500, Mark Hatle wrote:
> > On 9/21/17 4:15 PM, Otavio Salvador wrote:
> > > On Thu, Sep 21, 2017 at 2:46 PM, Tom Rini <trini@konsulko.com> wrote:
> > >> When we have been told to use the UUID we should also update the fstab
> > >> to make use of PARTUUID instead of hard-coding the device in question.
> > >> This will make the resulting image much more portable.
> > >>
> > >> Signed-off-by: Tom Rini <trini@konsulko.com>
> > > 
> > > Adding more features which changes the fstab goes to the opposite
> > > direction of reproducible builds; is it desirable?
> > 
> > There should be a corresponding way to specify the UUID for a generated
> > partition.  This would allow someone to pre-allocate the UUID and use it for
> > their generated image, and thus the reproducible build.
> 
> WIC does not today, but the underlying tools do, allow you to specify
> the UUID to use, yes.
> 

It does at least partly:

$ wic help kickstart |grep -A4 '\-\-uuid:'
         --uuid: This option is specific to wic. It specifies partition UUID.
                 It's useful if preconfigured partition UUID is added to kernel command line
                 in bootloader configuration before running wic. In this case .wks file can
                 be generated or modified to set preconfigured parition UUID using this option.

--
Regards,
Ed