Re: [PATCH] image_types: Fix bmaptool support for RSS

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

On Fri, Sep 29, 2017 at 02:16:21PM +0300, Ed Bartosh wrote:
> On Wed, Sep 27, 2017 at 01:00:09PM -0400, Tom Rini wrote:
> > With RSS we need to ensure that when making a bmap image that the
> > python3 that we created is found via /usr/bin/env rather than the host
> > python3.  Otherwise we're relying on the build host to have bmaptool
> > support installed.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > I played around with a few ways to try and fix this problem, and this
> > was the best I could come up with.  Once this is in we need this in pyro
> > as well as it's broken there too.
> > ---
> >  meta/classes/image_types.bbclass | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> > index 61dca626311e..3ff960e3a889 100644
> > --- a/meta/classes/image_types.bbclass
> > +++ b/meta/classes/image_types.bbclass
> > @@ -311,3 +311,6 @@ DEPLOYABLE_IMAGE_TYPES ?= "hddimg iso"
> >  # The IMAGE_TYPES_MASKED variable will be used to mask out from the IMAGE_FSTYPES,
> >  # images that will not be built at do_rootfs time: vmdk, vdi, qcow2, hdddirect, hddimg, iso, etc.
> >  IMAGE_TYPES_MASKED ?= ""
> > +
> > +# bmap requires python3 to be in the PATH
> > +EXTRANATIVEPATH += "${@'python3-native' if d.getVar('IMAGE_FSTYPES').find('bmap') else ''}"
> 
> +1
> 
> Would ...find('.bmap') be a bit more safe?

Could be.  Do I need to v2 or can someone just fix up while applying?
Thanks!

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]