From: Denys Dmytriyenko <denis@denix.org>
To: Andrea Galbusera <gizero@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
Date: Sat, 14 Oct 2017 22:01:38 -0400 [thread overview]
Message-ID: <20171015020138.GS9221@denix.org> (raw)
In-Reply-To: <CAC+thW1NdA_1zAVLf2jU+bQ+Mr58yBKFT_Gec4wXWiJRjfPFgw@mail.gmail.com>
On Sat, Oct 14, 2017 at 10:53:03PM +0200, Andrea Galbusera wrote:
> On Sat, Sep 30, 2017 at 10:15 AM, Chen Qi <Qi.Chen@windriver.com> wrote:
> > Add tools required by testimage to HOSTTOOLS only when testimage is
> > inherited. These tools, as described in the comment, are only required
> > by the testimage task. So this change should not have negtive effect.
> > This would also solve build error on hosts which miss some tool such as scp.
> >
> > Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> > ---
> > meta/conf/bitbake.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index f41680b..94c1f27 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -484,7 +484,7 @@ HOSTTOOLS += " \
> > "
> >
> > # Tools needed to run testimage runtime image testing
> > -HOSTTOOLS += "ip ping ps scp ssh stty"
> > +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> >
> > # Link to these if present
> > HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> This one is breaking any recipe that fetches from git repo with
> 'protocol=ssh' in its SRC_URI... I verified that reverting this one
> restores the usual fetcher behaviour. Should ssh be added to HOSTTOOLS
> unconditionally or is there any other way to approach it?
There's an entire thread discussing it here:
http://lists.openembedded.org/pipermail/openembedded-core/2017-October/143279.html
next prev parent reply other threads:[~2017-10-15 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 8:15 [PATCH 0/1] bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Chen Qi
2017-09-30 8:15 ` [PATCH 1/1] " Chen Qi
2017-10-14 20:53 ` Andrea Galbusera
2017-10-15 2:01 ` Denys Dmytriyenko [this message]
2017-10-15 13:35 ` Andrea Galbusera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171015020138.GS9221@denix.org \
--to=denis@denix.org \
--cc=gizero@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox