Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Thomas Perrot <thomas.perrot@tupi.fr>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [meta][pyro][PATCH] Fix some issues in the fitImage generation
Date: Tue, 17 Oct 2017 15:09:15 -0400	[thread overview]
Message-ID: <20171017190915.GI9221@denix.org> (raw)
In-Reply-To: <20171017165424.22887-1-thomas.perrot@tupi.fr>

On Tue, Oct 17, 2017 at 06:54:24PM +0200, Thomas Perrot wrote:
> - Bad image type replacement for aarch64
> - Fix DTB path in fitimage.its

I've seen the above 2 fixes before, but they never made it.


> - Ignore fitImage type during the packaging of the initramfs

Can you please explain this one a bit more?

And in general, commit message should rather explain "why" and not "what"


> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
> ---
>  meta/classes/kernel-fitimage.bbclass | 6 +++++-
>  meta/classes/kernel.bbclass          | 4 +++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 2630b47316..abbc309b09 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -7,8 +7,11 @@ python __anonymous () {
>          depends = "%s u-boot-mkimage-native dtc-native" % depends
>          d.setVar("DEPENDS", depends)
>  
> -        if d.getVar("UBOOT_ARCH") == "x86":
> +        uarch = d.getVar("UBOOT_ARCH")
> +        if uarch == "x86":
>              replacementtype = "bzImage"
> +        elif uarch == "arm64":
> +            replacementtype = "Image"
>          else:
>              replacementtype = "zImage"
>  
> @@ -351,6 +354,7 @@ fitimage_assemble() {
>  				DTB_PATH="arch/${ARCH}/boot/${DTB}"
>  			fi
>  
> +			DTB=$(echo "${DTB}" | tr '/' '_')
>  			DTBS="${DTBS} ${DTB}"
>  			fitimage_emit_section_dtb ${1} ${DTB} ${DTB_PATH}
>  		done
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index ce2cab65ae..a8b0d0a061 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -219,7 +219,9 @@ do_bundle_initramfs () {
>  		# Backing up kernel image relies on its type(regular file or symbolic link)
>  		tmp_path=""
>  		for type in ${KERNEL_IMAGETYPES} ; do
> -			if [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
> +			if [ "$type" == "fitImage" ] ; then
> +				continue
> +			elif [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
>  				linkpath=`readlink -n ${KERNEL_OUTPUT_DIR}/$type`
>  				realpath=`readlink -fn ${KERNEL_OUTPUT_DIR}/$type`
>  				mv -f $realpath $realpath.bak
> -- 
> 2.13.6
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


  parent reply	other threads:[~2017-10-17 19:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 16:54 [meta][pyro][PATCH] Fix some issues in the fitImage generation Thomas Perrot
2017-10-17 16:56 ` Burton, Ross
2017-10-18  7:00   ` André Draszik
2017-10-17 17:00 ` ✗ patchtest: failure for " Patchwork
2017-10-17 19:09 ` Denys Dmytriyenko [this message]
     [not found]   ` <BL2PR02MB2163A3231B9F61417D92A803B94C0@BL2PR02MB2163.namprd02.prod.outlook.com>
2017-10-17 22:20     ` [meta][pyro][PATCH] " Denys Dmytriyenko
     [not found]       ` <BL2PR02MB216333023A57FEE778BC75DCB94C0@BL2PR02MB2163.namprd02.prod.outlook.com>
2017-10-17 23:18         ` Denys Dmytriyenko
2017-10-18  7:02 ` André Draszik
2017-10-18  9:54   ` Thomas PERROT
  -- strict thread matches above, loose matches on Subject: below --
2017-10-18  7:46 Thomas Perrot
2017-10-18  8:09 ` André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017190915.GI9221@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.perrot@tupi.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox