From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mail.openembedded.org (Postfix) with ESMTP id 6279565CB6 for ; Tue, 7 Nov 2017 09:23:58 +0000 (UTC) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 07 Nov 2017 01:24:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,357,1505804400"; d="scan'208";a="146816097" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 07 Nov 2017 01:24:00 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id E5C265801E1; Tue, 7 Nov 2017 01:23:57 -0800 (PST) Date: Tue, 7 Nov 2017 10:11:35 +0200 From: Ed Bartosh To: Tom Rini Message-ID: <20171107081135.sqfjuwqw22tz46xw@linux.intel.com> Reply-To: ed.bartosh@linux.intel.com References: <1506015977-16858-1-git-send-email-trini@konsulko.com> <20171010210149.GE12015@bill-the-cat> <20171020131505.GG12015@bill-the-cat> <20171103125150.GA32663@bill-the-cat> <20171106100829.nqhna6hugyqe636k@linux.intel.com> <20171106124423.GG32663@bill-the-cat> MIME-Version: 1.0 In-Reply-To: <20171106124423.GG32663@bill-the-cat> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170421 (1.8.2) Cc: Otavio Salvador , Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/2] wic: When using --use-uuid make sure that we update the fstab with PARTUUID X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 09:23:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 06, 2017 at 07:44:23AM -0500, Tom Rini wrote: > On Mon, Nov 06, 2017 at 09:36:20AM -0200, Otavio Salvador wrote: > > On Mon, Nov 6, 2017 at 8:08 AM, Ed Bartosh wrote: > > > On Fri, Nov 03, 2017 at 08:51:50AM -0400, Tom Rini wrote: > > >> On Fri, Oct 20, 2017 at 09:15:05AM -0400, Tom Rini wrote: > > >> > On Tue, Oct 10, 2017 at 05:01:49PM -0400, Tom Rini wrote: > > >> > > On Thu, Sep 21, 2017 at 01:46:16PM -0400, Tom Rini wrote: > > >> > > > When we have been told to use the UUID we should also update the fstab > > >> > > > to make use of PARTUUID instead of hard-coding the device in question. > > >> > > > This will make the resulting image much more portable. > > >> > > > > > >> > > > Signed-off-by: Tom Rini > > >> > > > --- > > >> > > > scripts/lib/wic/plugins/imager/direct.py | 9 ++++++--- > > >> > > > 1 file changed, 6 insertions(+), 3 deletions(-) > > >> > > > > >> > > Where we did we end up with this? Ed pointed out that you can tell wic > > >> > > to use a specific UUID, so reproducible images are not a problem. And > > >> > > making images that are readily portable is why other distros use > > >> > > UUID/LABEL and not device names as much as possible. I personally enjoy > > >> > > being able to put an image on uSD for minnow and have it work :) > > >> > > Thanks! > > >> > > > >> > ping? > > >> > > >> I was just reminded about the real problems this solves (swap isn't > > >> /dev/sda3, boot is being excessively slow), so, ping? > > >> > > > > > > I'm generally ok with the patchset. The only thing I'm thinking of is if busybox mount > > > supports PARTUUID syntax in fstab. Can you check this, please? > > > > It does. > > It doesn't, you need util-linux for a mount that figures these out (or, > it did when I wrote the patch set). This practically means that this patch makes it impossible to use --use-uuid for busybox-powered images. This is quite a big regression from my point of view. We need to make this feature optional then. > That's why 2/2 only updates the > systemd canned wks as that _will_ have full mount. But please note that > you can already make a wks file that doesn't work with busybox mount by > using the --use-uuid flag for non-root partitions :) > What's the point of using --use-uuid for non-root partitions? I thought it only makes sense for root as it triggers update of kernel command line. > > > I'd like to see Otavio's confirmation that --uuid option solves > > > his reproducible builds concern. > > > > I am not against it if the no-fstab-update consider this too. Using > > uuid when making a fstab makes more sense but the possibility to not > > touch the fstab must be kept. > > Right. I'm only updating the systemd wks file to use this. Nothing > forces this option to be globally used. -- Regards, Ed