Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: openembedded-core@lists.openembedded.org,
	richard.purdie@linuxfoundation.org, bruce.ashfield@windriver.com
Subject: [PATCH 2/2] kernel-yocto: Stop the build if defconfig is missing
Date: Tue, 28 Nov 2017 19:28:18 -0800	[thread overview]
Message-ID: <20171129032818.2545-2-sgw@linux.intel.com> (raw)
In-Reply-To: <20171129032818.2545-1-sgw@linux.intel.com>

The bberror does not stop the build correctly, this should be a
bbfatal_log to ensure the failure correctly stops the build and logs
the failure.

Part of
[YOCTO #12162]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 98ec78fb768..2edf0fd1578 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -146,7 +146,7 @@ do_kernel_metadata() {
 	if [ -z "$bsp_definition" ]; then
 		echo "$sccs" | grep -q defconfig
 		if [ $? -ne 0 ]; then
-			bberror "Could not locate BSP definition for ${KMACHINE}/${LINUX_KERNEL_TYPE} and no defconfig was provided"
+			bbfatal_log "Could not locate BSP definition for ${KMACHINE}/${LINUX_KERNEL_TYPE} and no defconfig was provided"
 		fi
 	fi
 	meta_dir=$(kgit --meta)
-- 
2.13.6



  reply	other threads:[~2017-11-29  3:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  3:28 [PATCH 1/2] kernel-yocto: ensure sccs variable is set when using KBUILD_DEFCONFIG Saul Wold
2017-11-29  3:28 ` Saul Wold [this message]
2017-11-29  3:46 ` Bruce Ashfield
2017-11-29 14:23 ` Bruce Ashfield
2017-11-29 16:30   ` Saul Wold
2017-11-29 16:56     ` Bruce Ashfield
2017-11-29 17:52       ` Saul Wold
2017-11-29 18:13         ` Bruce Ashfield
2017-11-29 18:24           ` Saul Wold
2017-12-01  5:38             ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129032818.2545-2-sgw@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox