From: Mike Crowe <mac@mcrowe.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Otavio Salvador <otavio.salvador@ossystems.com.br>
Subject: Re: [PATCHv2] cmake: Avoid passing empty prefix to os.path.relpath
Date: Mon, 11 Dec 2017 09:51:49 +0000 [thread overview]
Message-ID: <20171211095149.ywhejbets5loutnv@mcrowe.com> (raw)
In-Reply-To: <CAP9ODKoxmsvO6ZaSNkYX3_-R234vvFoq3Ce6cWKDg_RE2tvMtg@mail.gmail.com>
On Monday 13 November 2017 at 15:15:35 -0200, Otavio Salvador wrote:
> On Sun, Nov 12, 2017 at 2:39 PM, Mike Crowe <mac@mcrowe.com> wrote:
> > With meta-micro, ${prefix} is the empty string. This means that
> > CMAKE_INSTALL_BINDIR:PATH and friends end up containing paths starting with
> > many instances of "../", presumably due to os.path.relpath attempting to
> > find its way to the current directory.
> >
> > Let's avoid this by ensuring that the root path always ends in a slash. If
> > it already ends in a slash then adding another one shouldn't cause any
> > problems.
> >
> > Signed-off-by: Mike Crowe <mac@mcrowe.com>
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Patch ID: 145709
It doesn't look like this change has landed, even on master-next. Has it
fallen through the cracks?
Thanks.
Mike.
next prev parent reply other threads:[~2017-12-11 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 16:39 [PATCHv2] cmake: Avoid passing empty prefix to os.path.relpath Mike Crowe
2017-11-13 17:15 ` Otavio Salvador
2017-12-11 9:51 ` Mike Crowe [this message]
2017-12-11 13:45 ` Burton, Ross
2017-12-20 10:28 ` Mike Crowe
2018-01-06 20:16 ` Mike Crowe
2019-06-11 13:58 ` Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211095149.ywhejbets5loutnv@mcrowe.com \
--to=mac@mcrowe.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox