Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org,
	Kristian Amlie <kristian.amlie@northern.tech>
Cc: openembedded-commits@lists.openembedded.org
Subject: Re: [oe-commits] [openembedded-core] 13/44: u-boot-fw-utils: Fix broken makefile in v2017.11.
Date: Tue, 2 Jan 2018 20:15:59 +0100	[thread overview]
Message-ID: <20180102191559.GA4180@localhost> (raw)
In-Reply-To: <20180102172800.BCD4523561F@git.openembedded.org>

[-- Attachment #1: Type: text/plain, Size: 3808 bytes --]

On Tue, Jan 02, 2018 at 05:28:13PM +0000, git@git.openembedded.org wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> rpurdie pushed a commit to branch master
> in repository openembedded-core.

Looks like older version of this patch was merged.

This version https://patchwork.openembedded.org/patch/146668/

adds the Upstream-Status from the commit message to the .patch file
where it belongs.

> commit bb6a45bc7e122c61386d0657e7c97895d1697bd7
> Author: Kristian Amlie <kristian.amlie@northern.tech>
> AuthorDate: Wed Dec 13 15:03:27 2017 +0100
> 
>     u-boot-fw-utils: Fix broken makefile in v2017.11.
>     
>     See the patch for details. This patch has already been applied
>     upstream, but we need it for v2017.11.
>     
>     Upstream-Status: Accepted [http://git.denx.de/?p=u-boot.git;a=commit;h=ded84f90a1066eef5f34daa4539273de64f7b811]
>     
>     Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  .../u-boot/files/v2017.11-fw-utils-build-fix.patch | 37 ++++++++++++++++++++++
>  meta/recipes-bsp/u-boot/u-boot-common_2017.11.inc  |  1 +
>  2 files changed, 38 insertions(+)
> 
> diff --git a/meta/recipes-bsp/u-boot/files/v2017.11-fw-utils-build-fix.patch b/meta/recipes-bsp/u-boot/files/v2017.11-fw-utils-build-fix.patch
> new file mode 100644
> index 0000000..fe89735
> --- /dev/null
> +++ b/meta/recipes-bsp/u-boot/files/v2017.11-fw-utils-build-fix.patch
> @@ -0,0 +1,37 @@
> +From ded84f90a1066eef5f34daa4539273de64f7b811 Mon Sep 17 00:00:00 2001
> +From: Stefan Agner <stefan.agner@toradex.com>
> +Date: Tue, 14 Nov 2017 15:47:18 +0100
> +Subject: [PATCH 1/1] envtools: make sure version/timestamp header file are
> + available
> +
> +With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> +the fw_env utilities need the version.h header file. Building only
> +the envtools in a pristine build directory will fail due to missing
> +header files.
> +
> +Make sure the header files are a dependency of the envtools target.
> +
> +Fixes: 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> +Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> +Tested-by: Peter Robinson <pbrobinson@gmail.com>
> +Reviewed-by: Simon Glass <sjg@chromium.org>
> +---
> + Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile b/Makefile
> +index 61fd973..f8c66a2 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -1447,7 +1447,7 @@ checkarmreloc: u-boot
> + 		false; \
> + 	fi
> + 
> +-envtools: scripts_basic
> ++envtools: scripts_basic $(version_h) $(timestamp_h)
> + 	$(Q)$(MAKE) $(build)=tools/env
> + 
> + tools-only: scripts_basic $(version_h) $(timestamp_h)
> +-- 
> +2.7.4
> +
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.11.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.11.inc
> index bfdf1a0..65f1228 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2017.11.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.11.inc
> @@ -12,6 +12,7 @@ SRCREV = "c253573f3e269fd9a24ee6684d87dd91106018a5"
>  SRC_URI = "git://git.denx.de/u-boot.git \
>      file://MPC8315ERDB-enable-DHCP.patch \
>      file://10m50-update-device-tree.patch \
> +    file://v2017.11-fw-utils-build-fix.patch \
>  "
>  
>  S = "${WORKDIR}/git"
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

       reply	other threads:[~2018-01-02 19:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <151491408002.12536.9555639223209873731@git.openembedded.org>
     [not found] ` <20180102172800.BCD4523561F@git.openembedded.org>
2018-01-02 19:15   ` Martin Jansa [this message]
2018-01-02 22:42     ` [oe-commits] [openembedded-core] 13/44: u-boot-fw-utils: Fix broken makefile in v2017.11 Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102191559.GA4180@localhost \
    --to=martin.jansa@gmail.com \
    --cc=kristian.amlie@northern.tech \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox