Re: [PATCHv2 0/5] Enable wic in eSDK

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Thu, Jan 11, 2018 at 10:55:18PM +0800, rebecca.swee.fun.chang@intel.com wrote:
> Hi all,
> 
> As the subject called out: this patch series enable wic in eSDK.
> The details of what I have done are documented within the commit message.
> Basically wic requires an OE build environment, but we are using a
> different environment setup script in eSDK. Hence, I have added some
> code for wic to explicitly export bitbake variables within eSDK. I
> have also make wic to use the shared code in scriptpath for oe lib
> and bitbake path addition to sys.path.
> 
> I have run the changes on wic oe-selftest and the tests are passing.
> What's next: I think it would better to have some test cases
> for wic within eSDK if this series are merged.
> 

Would it make sense to cover this new functionality by tests?

> 
> The following changes since commit 364f8bcfcbd04e722490f363ad36a15fb7066ba7:
> 
>   linux-firmware: Bump revision to 65b1c68c (2018-01-11 10:26:07 +0000)
> 
> are available in the Git repository at:
> 
>   git://push.yoctoproject.org/poky-contrib rebeccas/wic-dev
> 
> Chang Rebecca Swee Fun (5):
>   scripts/wic: use scriptpath module to find bitbake path and oe lib
>     path
>   scripts/wic: append bitbake executable file path in eSDK environment
>   scripts/wic: fix error of import wic module in eSDK environment
>   scripts/wic: explicitly set BUILDDIR within eSDK
>   classes/populate_sdk_ext: support wic in eSDK
> 
>  meta/classes/populate_sdk_ext.bbclass |  2 +-
>  scripts/wic                           | 23 ++++++++++++++++++-----
>  2 files changed, 19 insertions(+), 6 deletions(-)
> 
> -- 
> 2.15.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
--
Regards,
Ed